Appends cache namespace when it exists (for L2C regions) #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius should we also port it for 2.5.x? |
lcobucci
force-pushed
the
fix-l2c-region-namespace
branch
from
52e24ed
to
a722785
Compare
Ocramius
previously requested changes
Jan 11, 2017
| $factory = new DefaultCacheFactory($this->regionsConfig, $cache); | ||
|
|
||
| $fooRegion = $factory->getRegion( | ||
| [ |
|
|
||
| $namespace = $cacheAdapter->getNamespace(); | ||
|
|
||
| if (!empty($namespace)) { |
There was a problem hiding this comment.
Please use '' === $namespace, unless getNamespace only allows string as return value
| ] | ||
| ); | ||
| $barRegion = $factory->getRegion( | ||
| [ |
| ); | ||
|
|
||
| $this->assertSame('testing:foo', $fooRegion->getCache()->getNamespace()); | ||
| $this->assertSame('testing:bar', $barRegion->getCache()->getNamespace()); |
There was a problem hiding this comment.
Are prefixes for non-namespaced caches checked in some existing tests??
There was a problem hiding this comment.
We're overriding the namespace without even checking if it was previously set, what causes problems when people uses that feature 😉
lcobucci
force-pushed
the
fix-l2c-region-namespace
branch
from
a722785
to
eaedc37
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're overriding the namespace without even checking if it was previously set, what causes problems when people uses that feature 😉