Use getMultiple() to fetch associations as well in L2 cache fetch operations
#6245
Conversation
|
btw I know this is a bit messy, so please suggest a nice way to improve this (I'm a bit sleepy right now) |
| @@ -178,14 +176,20 @@ public function get(QueryCacheKey $key, ResultSetMapping $rsm, array $hints = [] | |||
| continue; | |||
| } | |||
|
|
|||
| $collection = new PersistentCollection($this->em, $assocMetadata, new ArrayCollection()); | |||
| $generateKeys = function ($id) use ($assocMetadata): EntityCacheKey { | |||
There was a problem hiding this comment.
master already dropped PHP 5.6
There was a problem hiding this comment.
@guilhermeblanco we dropped PHP 5 support in master as well
|
Hello, This PR will be merged to the 2.6 version that's right? The PR is still in improvement? |
|
@LuffyLyon this is only for 2.6 indeed and @Ocramius wanted to have some tests but we bumped into mocking hell. We still need to decide what to do with it (there're some duplications that I'm not really happy with) |
|
Ok thank you, which duplications are you talking about? Maybe I can contribute to improving this feature |
lcobucci
force-pushed
the
l2c-use-getMultiple
branch
from
f79860d
to
ccaa4b8
Compare
Ocramius
changed the title
getMultiple() to fetch associations as wellgetMultiple() to fetch associations as well in L2 cache fetch operations
Just as it was done on #5831