Fixing #5887 - lazy loading of one-to-one relationship with custom id object #6274
Conversation
| * @Entity | ||
| * @Table(name="issue5887_cart") | ||
| */ | ||
| class Issue5887Cart |
There was a problem hiding this comment.
Please move this class to the test file (like we have here).
|
|
||
| namespace Doctrine\Tests\Models\Issue5887; | ||
|
|
||
| class Issue5887CustomIdObject |
There was a problem hiding this comment.
Please move this class to the test file (like we have here).
| use Doctrine\DBAL\Platforms\AbstractPlatform; | ||
| use Doctrine\DBAL\Types\Type; | ||
|
|
||
| class Issue5887CustomIdObjectType extends Type |
There was a problem hiding this comment.
Please move this class to the test file (like we have here).
There was a problem hiding this comment.
It can also inherit StringType instead so you don't need to implement the method getSQLDeclaration().
| * @Entity | ||
| * @Table(name="issue5887_customer") | ||
| */ | ||
| class Issue5887Customer |
There was a problem hiding this comment.
Please move this class to the test file (like we have here).
| @@ -16,7 +16,7 @@ static public function dataValidateModelSets() | |||
| { | |||
| $modelSets = []; | |||
| foreach (self::$_modelSets as $modelSet => $classes) { | |||
| if ($modelSet == "customtype") { | |||
| if (in_array($modelSet, ["customtype", "issue5887"])) { | |||
There was a problem hiding this comment.
Not needed for inlined classes
| @@ -302,6 +302,10 @@ | |||
| Models\Issue5989\Issue5989Employee::class, | |||
| Models\Issue5989\Issue5989Manager::class, | |||
| ], | |||
| 'issue5887' => [ | |||
There was a problem hiding this comment.
Not needed for inlined classes
| @@ -576,6 +580,11 @@ protected function tearDown() | |||
| $conn->executeUpdate('DELETE FROM issue5989_managers'); | |||
| } | |||
|
|
|||
| if (isset($this->_usedModelSets['issue5887'])) { | |||
There was a problem hiding this comment.
Not needed for inlined classes
|
@lcobucci Thanks for looking into this. I've applied changes regarding your comments and simplified test case to test only the most basic case I could come up with. The problem is not with the first query for If you remove the applied change in |
Fixing case when lazy loading of entity in one-to-one relationship on the side without foreign key did not return eht entity because of custom type not being detected and properly formatted before applying to database query. Closes #5887
|
@necsord I've just rebased your branch to sync with Thanks for your contribution 😉 |
Fixing case when lazy loading of entity in one-to-one relationship on the side without foreign key
did not return the entity because of custom type not being detected and properly formatted before
applying to database query.