Correct DQL `INSTANCE OF` to filter all possible child classes #6392

Jean85 · 2017-04-12T08:02:02Z

This is the rebased version of #1441, which fixes #4646.
Here is the original text:

There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg

"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).

This commit also provides useful tests to avoid regression.

There was a bug in the "INSTANCE OF" operator as described in https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg "INSTANCE OF" was not taking into account subclasses. It was merely translating the class to its discriminator. This is not correct since the class can have subtypes and those are, indeed, still instance of the superclass. Also, classes may not have a discriminator (e.g. abstract classes). This commit also provides useful tests to avoid regression.

phansys

Status: Needs work.

phansys · 2017-04-14T20:02:32Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfTest.php

+        {
+            parent::setUp();
+
+            $this->_schemaTool->createSchema(array(


Please, use short array syntax instead.

phansys · 2017-04-14T20:06:16Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+            $this->assertCount(1, $result);
+
+            foreach ($result as $r) {
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Person', $r);


Please, use ::class constant instead of hardcoding the QCN here.

phansys · 2017-04-14T20:06:34Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+            foreach ($result as $r) {
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Person', $r);
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Employee', $r);
+                $this->assertEquals('bar', $r->getName());


Please, use assertSame() instead.

Jean85 · 2017-04-18T09:58:07Z

All done, thanks for the review @phansys

lcobucci

Can you please extract some methods from SqlWalker#walkInstanceOfExpression() it was already messy and now it's a bit harder to understand things properly.

Also could you try to relate the tests, and entities that each test use, to the ticket (as we have on Functional\Ticket classes) just to keep the "standard" we're having...

lcobucci · 2017-04-12T08:47:54Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+        {
+            parent::setUp();
+
+            $this->_schemaTool->createSchema(array(


Please use short array syntax

lcobucci · 2017-04-12T08:48:04Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+            parent::setUp();
+
+            $this->_schemaTool->createSchema(array(
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfAbstractTest\Person'),


Please use ::class syntax

lcobucci · 2017-04-12T08:49:00Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+            $this->assertCount(1, $result);
+
+            foreach ($result as $r) {
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Person', $r);


Please use ::class syntax

lcobucci · 2017-04-12T08:49:05Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+
+            foreach ($result as $r) {
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Person', $r);
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Employee', $r);


Please use ::class syntax

lcobucci · 2017-04-12T08:49:09Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+
+            $this->_schemaTool->createSchema(array(
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfAbstractTest\Person'),
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfAbstractTest\Employee'),


Please use ::class syntax

lcobucci · 2017-04-12T08:51:38Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfAbstractTest.php

+     * @InheritanceType(value="JOINED")
+     * @DiscriminatorColumn(name="kind", type="string")
+     * @DiscriminatorMap(value={
+     *     "employee": "Doctrine\Tests\ORM\Functional\InstanceOfAbstractTest\Employee"


You can use "employee": Employee::class

lcobucci · 2017-04-12T08:52:42Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfMultiLevelTest.php

+            parent::setUp();
+
+            $this->_schemaTool->createSchema(array(
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Person'),


Please use ::class syntax

lcobucci · 2017-04-12T08:52:46Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfMultiLevelTest.php

+
+            $this->_schemaTool->createSchema(array(
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Person'),
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Employee'),


Please use ::class syntax

lcobucci · 2017-04-12T08:52:50Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfMultiLevelTest.php

+            $this->_schemaTool->createSchema(array(
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Person'),
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Employee'),
+                $this->_em->getClassMetadata(__NAMESPACE__ . '\InstanceOfMultiLevelTest\Engineer'),


Please use ::class syntax

lcobucci · 2017-04-12T08:52:55Z

tests/Doctrine/Tests/ORM/Functional/InstanceOfMultiLevelTest.php

+            $this->assertCount(3, $result);
+
+            foreach ($result as $r) {
+                $this->assertInstanceOf('Doctrine\Tests\ORM\Functional\InstanceOfMultiLevelTest\Person', $r);


Please use ::class syntax

Jean85 · 2017-05-03T09:07:15Z

Thanks for the review @lcobucci!
I hope that I addressed al your concerns with my latest commits.

Jean85 · 2017-05-03T09:43:39Z

A lot of tests are failing, probably for an unrelated issue... should I rebase? Or merge master?

[EDIT] Scrap that, the build is green 👍

Ocramius · 2017-06-21T06:44:00Z

lib/Doctrine/ORM/Query/SqlWalker.php

+                $currentMetadata = $this->em->getClassMetadata($class);
+                $currentDiscriminator = $currentMetadata->discriminatorValue;
+
+                if (is_string($currentDiscriminator) && ! array_key_exists($currentDiscriminator, $discriminators)) {


A discriminator may be also an integer or similar - why do you want this to only work with string?

I didn't know! I'll do a !== null then.

Ocramius · 2017-06-21T06:47:12Z

lib/Doctrine/ORM/Query/SqlWalker.php

+            }
+
+            // Trim first backslash
+            $parameter = ltrim($parameter, '\\');


You should do $this->em->getClassMetadata($parameter); here - this already provides the ltrim() logic for you (internally)

Right! I was also already doing the getClassMetadata a few lines after, I'll just move that up!

Ocramius · 2017-06-21T06:47:34Z

lib/Doctrine/ORM/Query/SqlWalker.php

+            // Trim first backslash
+            $parameter = ltrim($parameter, '\\');
+
+            if ($parameter !== $discrClass->name && ! array_key_exists($parameter, $knownSubclasses)) {


$metadata->getClass()->isSubclassOf(...) maybe?

This also has the effect of getting rid of INSTANCE OF checks where INSTANCE OF is pointing at the topmost class (which is most likely a bug in userland code)

Ocramius · 2017-06-21T06:49:33Z

lib/Doctrine/ORM/Query/SqlWalker.php

+                $currentDiscriminator = $currentMetadata->discriminatorValue;
+
+                if (is_string($currentDiscriminator) && ! array_key_exists($currentDiscriminator, $discriminators)) {
+                    $discriminators[$currentDiscriminator] = true;


Consider using null if that true has no meaning

Ocramius · 2017-06-21T06:50:03Z

lib/Doctrine/ORM/Query/SqlWalker.php

+            $sqlParameterList[] = $this->conn->quote($dis);
+        }
+
+        return '(' . implode(', ', $sqlParameterList) . ')';


According to this logic, the list may be empty, leading to a crash

How that could happen? Since I check if the class is unrelated at line 2297, at least one discriminator should pop up, or an exception be thrown...

Yeah, but that flow makes it hard to follow: ideally we should array_map() over $instanceOfExpr->value, but let's see where the code goes after the additional tests provided by @taueres

Ocramius · 2017-06-21T06:50:28Z

lib/Doctrine/ORM/Query/SqlWalker.php

+        }
+
+        foreach (array_keys($discriminators) as $dis) {
+            $sqlParameterList[] = $this->conn->quote($dis);


array_map([$this->conn, 'quote'], array_keys($discriminators))

We may already have values inside $sqlParameterList, see line 2289, so I think it's better to do it like that.

Then just array_merge() with it

Ocramius · 2017-06-21T06:50:55Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfAbstractTest.php

@@ -0,0 +1,114 @@
+<?php
+
+namespace Doctrine\Tests\ORM\Functional\Ticket {


Please put the entire file under a single namespace

Ocramius · 2017-06-21T06:51:44Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfMultiLevelTest.php

+         */
+        private $specialization;
+
+        public function getSpecialization()


Remove all accessors that aren't strictly needed: prefer public properties if they are needed (although note that these tests don't really need the properties to work, so you should drop everything but the identifier)

Ocramius · 2017-06-21T06:52:48Z

tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php

@@ -502,7 +502,7 @@ public function testSupportsInstanceOfExpressionsInWherePart()
    {
        $this->assertSqlGeneration(
            "SELECT u FROM Doctrine\Tests\Models\Company\CompanyPerson u WHERE u INSTANCE OF Doctrine\Tests\Models\Company\CompanyEmployee",
-            "SELECT c0_.id AS id_0, c0_.name AS name_1, c0_.discr AS discr_2 FROM company_persons c0_ WHERE c0_.discr IN ('employee')"
+            "SELECT c0_.id AS id_0, c0_.name AS name_1, c0_.discr AS discr_2 FROM company_persons c0_ WHERE c0_.discr IN ('manager', 'employee')"


Ouch, this is a bad bug. Good catch!

All credits to @taueres !

Jean85 · 2017-06-21T13:02:59Z

Ok seems that I've addressed all your concerns, @Ocramius @lcobucci
Build is green with low deps, other failures seems unrelated, maybe they come from master?

taueres · 2017-06-21T20:02:41Z

Hi! Thank you very much for resuming this PR, I really appreciate that!
I checked this fix once more but unfortunately the issue still occurs when using INSTANCE OF with parameters.

Here is an example:

$dql = 'SELECT p FROM Person p WHERE p INSTANCE OF :parameter';
$query = $em->createQuery($dql);
$query->setParameter('parameter', $em->getClassMetadata(Person::class));

// $result contains only direct instances of `Person`, no subclasses
$result = $query->getResult();

I guess we need to change something about parameter resolution. I'll definitely have a look in the following days.

taueres · 2017-06-21T20:21:10Z

I wrote a failing test case for the issue I mentioned before: https://gist.github.com/taueres/05ff035bb2f72cddd7711b7f93cd9d6a

Jean85 · 2017-06-22T07:38:17Z

Thanks @taueres!
I've found that your test case fails also when doing this:

$dql = 'SELECT p FROM Doctrine\Tests\ORM\Functional\Ticket\PersonTicket4646Parametric p
        WHERE p INSTANCE OF :parameter';
$query = $this->_em->createQuery($dql);
$query->setParameter(
    'parameter',
    PersonTicket4646Parametric::class
);

Do we want to check for this additional uses, @Ocramius ?

Ocramius · 2017-06-22T07:45:06Z

$query->setParameter(
    'parameter',
    PersonTicket4646Parametric::class
);

This currently requires binding a ClassMetadata instance:

$query->setParameter(
    'parameter',
    $em->getClassMetadata(PersonTicket4646Parametric::class)
);

We can fix it, yes

…INSTANCE OF

Jean85 · 2017-06-22T07:51:38Z

Ok I've added the failing test case. I'll try to work on that soon; @taueres if you have any tips, I'm all ears! 😄

There was a bug in the "INSTANCE OF" operator as described in https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg "INSTANCE OF" was not taking into account subclasses. It was merely translating the class to its discriminator. This is not correct since the class can have subtypes and those are, indeed, still instance of the superclass. Also, classes may not have a discriminator (e.g. abstract classes). This commit also provides useful tests to avoid regression.

taueres · 2017-07-07T14:11:16Z

To solve the duplication issue we could create something like:

class HierarchyDiscriminatorResolver
{
    public static function resolveDiscriminatorsForClass(ClassMetadata $rootClassMetadata, EntityManagerInterface $entityManager)
    {
        /* Duplicate code goes here */
        /* return list of discriminator */
    }
}

In the proposed solution, the EntityManager dependency is needed in order to retrieve ClassMetadata for subClasses.

I would not put such logic into ClassMetadata because atm ClassMetadata is not coupled to EntityManager.

Jean85 · 2017-07-07T15:22:36Z

This seems a feasible solution for me... @Ocramius ? What do you think?

Ocramius · 2017-08-18T02:47:22Z

@Jean85 as long as the class is marked as @internal, sure 👍

Totally missed these comments before btw.

Jean85 · 2017-08-18T08:28:23Z

Don't worry @Ocramius, I was on vacation anyway 😄
Deduplication of code done, build is green, this is ready for a final review!

Ocramius · 2017-08-18T08:36:58Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+ * @package Doctrine\ORM\Utility
+ * @internal This class exists only to avoid code duplication, do not reuse it externally
+ */
+class HierarchyDiscriminatorResolver


This class needs to be tested in isolation

Ocramius · 2017-08-18T08:37:04Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+use Doctrine\ORM\EntityManagerInterface;
+
+/**
+ * Class HierarchyDiscriminatorResolver


Remove this line

Ocramius · 2017-08-18T08:37:08Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+
+/**
+ * Class HierarchyDiscriminatorResolver
+ * @package Doctrine\ORM\Utility


Remove this line

Ocramius · 2017-08-18T08:37:25Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+ */
+class HierarchyDiscriminatorResolver
+{
+    public static function resolveDiscriminatorsForClass(


Add a private constructor

An explanation of the method is needed

Ocramius · 2017-08-18T08:37:30Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+    public static function resolveDiscriminatorsForClass(
+        ClassMetadata $rootClassMetadata,
+        EntityManagerInterface $entityManager
+    ) {


Return type

Sorry, I forgot that the target branch is 7+! Good!

Ocramius · 2017-08-18T08:37:52Z

lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php

+        $hierarchyClasses[] = $rootClassMetadata->name;
+
+        $discriminators = [];
+        foreach ($hierarchyClasses as $class) {


Empty line before logical blocks

You should enforce this in the Lint stage of the CI!

We're going to 😉

taueres · 2017-08-18T08:57:46Z

According to the DQL spec. Users can provide multiple classes for an INSTANCE OF statement.

InstanceOfExpression     ::= IdentificationVariable ["NOT"] "INSTANCE" ["OF"]
    (InstanceOfParameter | "(" InstanceOfParameter {"," InstanceOfParameter}* ")")

Do we have some tests covering this specific use case?

lcobucci

Some nitpicking 😄

lcobucci · 2017-08-18T08:55:24Z

lib/Doctrine/ORM/Query/SqlWalker.php

+     * @return string The list in parentheses of valid child discriminators from the given class
+     * @throws QueryException
+     */
+    private function getChildDiscriminatorsFromClassMetadata(ClassMetadataInfo $rootClass, AST\InstanceOfExpression $instanceOfExpr)


Please add the return type declaration

lcobucci · 2017-08-18T08:57:47Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfAbstractTest.php

+
+class Ticket4646InstanceOfAbstractTest extends OrmFunctionalTestCase
+{
+    protected function setUp()


lcobucci · 2017-08-18T08:57:52Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfAbstractTest.php

+        ]);
+    }
+
+    public function testInstanceOf()


lcobucci · 2017-08-18T08:58:20Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfAbstractTest.php

+        $query = $this->_em->createQuery($dql);
+        $result = $query->getResult();
+
+        $this->assertCount(1, $result);


Please use self::assert* for new tests

lcobucci · 2017-08-18T08:58:30Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfMultiLevelTest.php

+
+class Ticket4646InstanceOfMultiLevelTest extends OrmFunctionalTestCase
+{
+    protected function setUp()


lcobucci · 2017-08-18T08:59:37Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfTest.php

+        ]);
+    }
+
+    public function testInstanceOf()


lcobucci · 2017-08-18T08:59:53Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfMultiLevelTest.php

+     */
+    private $id;
+
+    public function getId()


lcobucci · 2017-08-18T09:00:01Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfParametricTest.php

+     */
+    private $id;
+
+    public function getId()


lcobucci · 2017-08-18T09:00:10Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfTest.php

+        $query = $this->_em->createQuery($dql);
+        $result = $query->getResult();
+
+        $this->assertCount(2, $result);


lcobucci · 2017-08-18T09:00:14Z

tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket4646InstanceOfTest.php

+     */
+    private $id;
+
+    public function getId()


Jean85 · 2017-08-18T10:36:17Z

@lcobucci @Ocramius done as per review!

Jean85 · 2017-08-18T11:10:42Z

I've also added a new functional test to cover the case of multiple parameters passed to the INSTANCEOF, as suggested by @taueres

[EDIT] Sorry, made a mistake, fixing the build now

…rameters

Review comments handled

Ocramius

LGTM 👍 🚢

Ocramius · 2017-08-18T19:36:35Z

Thanks @Jean85 @taueres and @phansys!

phansys suggested changes Apr 14, 2017

View reviewed changes

Fix as per review

4eb4465

lcobucci suggested changes May 1, 2017

View reviewed changes

Jean85 added 3 commits May 3, 2017 10:46

Fix small CS issues as per review

3219fe5

Split SqlWalker::walkInstanceOfExpression method

11c84c7

Move tests to ticket namespace (and rename them)

21e12ef

Fix test

96bcee4

Ocramius suggested changes Jun 21, 2017

View reviewed changes

Ocramius added the Bug label Jun 21, 2017

Jean85 added 4 commits June 21, 2017 09:34

Refactor a bit the SqlWalker modifications

30256e7

Apply additional fixes to the SqlWalker to fix tests

11c54b7

Put all tests classes in a single namespace

8b9c297

Simplify stubs used in tests

ba69cc8

Adding a failing test case for parameter binding using metadata with …

d4cdc6e

…INSTANCE OF

lcobucci added this to Review in ORM v2.6.x Jun 23, 2017

Ocramius changed the title ~~[REBASED][QUERY] "INSTANCE OF" now behaves correctly with subclasses~~ Correct DQL INSTANCE OF to filter all possible child classes Jun 24, 2017

taueres and others added 4 commits June 24, 2017 10:58

Fix as per review

04acde6

Fix small CS issues as per review

aa233f8

Split SqlWalker::walkInstanceOfExpression method

0e88f1b

Ocramius self-assigned this Jun 26, 2017

Ocramius assigned Jean85 and unassigned Ocramius Aug 18, 2017

Ocramius added WIP and removed Requires merge/review labels Aug 18, 2017

Remove code duplication of the getAllDiscriminators method

d4db126

Ocramius suggested changes Aug 18, 2017

View reviewed changes

lcobucci previously requested changes Aug 18, 2017

View reviewed changes

Jean85 added 3 commits August 18, 2017 11:02

Apply various and CS fixes as per review

5224a89

Add unit test for HierarchyDiscriminatorResolverTest

9864a5a

Add more CS fixes

19bc499

Jean85 force-pushed the pr_1441_rebased branch from 84f6861 to f8c267b Compare August 18, 2017 12:42

Add new functional test to check usage of INSTANCEOF with multiple pa…

c799c6d

…rameters

Jean85 force-pushed the pr_1441_rebased branch from f8c267b to c799c6d Compare August 18, 2017 12:50

Ocramius removed the WIP label Aug 18, 2017

Ocramius approved these changes Aug 18, 2017

View reviewed changes

Ocramius merged commit 1a0bb82 into doctrine:master Aug 18, 2017

Jean85 deleted the pr_1441_rebased branch August 22, 2017 09:24

lcobucci moved this from Review to Done in ORM v2.6.x Sep 2, 2017

lcobucci mentioned this pull request Jan 15, 2018

Doctrine 2.6 : Inheritance (instance of) does not work #6979

Closed

		@@ -0,0 +1,114 @@
		<?php

		namespace Doctrine\Tests\ORM\Functional\Ticket {

Correct DQL INSTANCE OF to filter all possible child classes #6392

Correct DQL INSTANCE OF to filter all possible child classes #6392

Conversation

Jean85 commented Apr 12, 2017

phansys left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jean85 commented Apr 18, 2017

lcobucci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jean85 commented May 3, 2017

Jean85 commented May 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jean85 commented Jun 21, 2017

taueres commented Jun 21, 2017 • edited Loading

taueres commented Jun 21, 2017

Jean85 commented Jun 22, 2017

Ocramius commented Jun 22, 2017

Jean85 commented Jun 22, 2017

taueres commented Jul 7, 2017

Jean85 commented Jul 7, 2017

Ocramius commented Aug 18, 2017

Jean85 commented Aug 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcobucci Aug 18, 2017 • edited Loading

Choose a reason for hiding this comment

taueres commented Aug 18, 2017 • edited Loading

lcobucci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jean85 commented Aug 18, 2017

Jean85 commented Aug 18, 2017 • edited Loading

Ocramius left a comment

Choose a reason for hiding this comment

Correct DQL `INSTANCE OF` to filter all possible child classes #6392

Correct DQL `INSTANCE OF` to filter all possible child classes #6392

Jean85 commented May 3, 2017 •

edited

Loading

taueres commented Jun 21, 2017 •

edited

Loading

lcobucci Aug 18, 2017 •

edited

Loading

taueres commented Aug 18, 2017 •

edited

Loading

Jean85 commented Aug 18, 2017 •

edited

Loading