Fix #6460 - \Doctrine\ORM\Mapping\ClassMetadataInfo::hasField should return true for embedded fields #6462
Conversation
… should return true for embedded fields
| $this->_em->getClassMetadata(DDC6460ParentEntity::class), | ||
| ] | ||
| ); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Please only catch schemaexception
| ->getClassMetadata(DDC6460Entity::class) | ||
| ->hasField('embedded'); | ||
|
|
||
| $this->assertTrue($isFieldMapped); |
There was a problem hiding this comment.
This test should probably be on the class metadata tests
There was a problem hiding this comment.
I've added similar test there
|
|
||
| $proxy = $this->_em->getRepository(DDC6460ParentEntity::class)->findOneById(1); | ||
|
|
||
| $this->assertNotNull($proxy->lazyLoaded->embedded); |
There was a problem hiding this comment.
Please use self::assertInstanceOf()
There was a problem hiding this comment.
I would also check the value of field after this call
| $second->id = 1; | ||
| $second->lazyLoaded = $entity; | ||
| $this->_em->persist($second); | ||
| $this->_em->flush(); |
There was a problem hiding this comment.
I've added cascade persist in order to remove one flush
|
|
||
| $this->_em->clear(); | ||
|
|
||
| $proxy = $this->_em->getRepository(DDC6460ParentEntity::class)->findOneById(1); |
There was a problem hiding this comment.
This is not a proxy here: please add assertions to verify if it is a proxy, and if it is loaded
| $second->id = 1; | ||
| $second->lazyLoaded = $entity; | ||
| $this->_em->persist($second); | ||
| $this->_em->flush(); |
|
LGTM! 👍 Note that I'm not changing this for |
This fixes #6460