Updating docs to support for APCu as a cache driver #6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jul 30, 2017
| <?php | ||
| $cacheDriver = new \Doctrine\Common\Cache\ApcuCache(); | ||
| $cacheDriver->save('cache_id', 'my_data'); | ||
|
|
There was a problem hiding this comment.
I'd put it above the doc for APC, which is deprecated (maybe add a note about that, or even consider removing it?)
greg0ire
reviewed
Jul 30, 2017
docs/en/reference/caching.rst
Outdated
| @@ -63,6 +63,24 @@ by itself. | |||
| $cacheDriver = new \Doctrine\Common\Cache\ApcCache(); | |||
| $cacheDriver->save('cache_id', 'my_data'); | |||
|
|
|||
| APCu | |||
| ~~~ | |||
|
APC is used in examples for the query cache or the result cache, should be replaced with APCu IMO: https://github.com/doctrine/doctrine2/blob/cd11723e6310b5973f50e7d9819c58916721d290/docs/en/reference/caching.rst |
greg0ire
reviewed
Jul 30, 2017
docs/en/reference/caching.rst
Outdated
| @@ -60,7 +60,25 @@ by itself. | |||
| .. code-block:: php | |||
|
|
|||
| <?php | |||
| $cacheDriver = new \Doctrine\Common\Cache\ApcCache(); | |||
| $cacheDriver = new \Doctrine\Common\Cache\ApcuCache(); | |||
There was a problem hiding this comment.
You don't want to change that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.