Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the configuration support "keepSlave"? #102

Closed
jonathaningram opened this issue Aug 30, 2012 · 3 comments
Closed

Should the configuration support "keepSlave"? #102

jonathaningram opened this issue Aug 30, 2012 · 3 comments

Comments

@jonathaningram
Copy link
Contributor

In DBAL's MasterSlaveConnection, it supports the keepSlave option:

$this->keepSlave = isset($params['keepSlave']) ? (bool)$params['keepSlave'] : false;

@stof is there any reason you chose to not add it when you implemented #53?

I am finding that the slave is overwritten (and ignored) because of calls to SET NAMES UTF8 in the same request so I'd like to be able to configure this in the options.

Note: a current work around I am using to to wrap DBAL's MasterSlaveConnection in my own class and just set the keepSlave setting to true in the constructor. This is hard-coded though, not configurable.

@stof
Copy link
Member

stof commented Aug 30, 2012

The reason is that keepSlave has been added in DBAL 2 months ago, so 3 months after the PR you linked :)

@jonathaningram
Copy link
Contributor Author

Ah that would make sense. I'll make a PR.

@stof
Copy link
Member

stof commented Aug 30, 2012

Fixed by #103

@stof stof closed this as completed Aug 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants