Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To increase debuggability, hide SELECT clause fields by default and only show on hover. #107

Closed
beberlei opened this issue Sep 7, 2012 · 3 comments
Labels

Comments

@beberlei
Copy link
Member

beberlei commented Sep 7, 2012

In large queries, the SELECT clause takes up most of the query, however this is the least interesting part. We should hide it in the debug bar unless a user specifically requests to see it. (Javascript)

@dlsniper
Copy link
Contributor

dlsniper commented Sep 9, 2012

I've found https://github.com/jdorn/sql-formatter and I've opened an issue with the original author to see if I can use his work into DoctrineBundle. I believe it would further improve the usability of the debugging section while adding a pretty neat feature.

If he approves the usage, what do you guys think about including it?

I'll do all the work for it should everyone agree with it.

cc @stof @guilhermeblanco

Thanks!

@dlsniper
Copy link
Contributor

Hi,

@jdorn just agreed with the use of his library in DoctrineBundle.

Are you guys ok with that as well?

And if so, what do you think it's the best way to include it in? Via a composer dependency I suppose?

Thanks.

@dlsniper
Copy link
Contributor

Hi,

I've been working today to come with a demo and here's what it looks like currently: http://sf2demo.rodb.ro/app_dev.php/

I've also added the ability to sort the queries by how much did they run in descending order as I think it's useful to have something like that ;)

I'll create a PR soonish, meanwhile please tell me if it's something you'd like to merge in or how can I improve it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants