Fixing tests

[schmittjoh]

@jmikola, we have a failing test case related to the refactoring of the RegisterEventListenersSubscribersPass, could you take a look?

[jmikola]

Will do.

[jmikola]

Are you sure?

[avocado: DoctrineBundle] master $ ./composer.phar install --install-suggests
Installing dependencies
  - Package twig/twig (1.6.1)
    Downloading                                                                 
    Unpacking archive
    Cleaning up

  - Package doctrine/dbal (2.2.1)
    Downloading                                                                 
    Unpacking archive
    Cleaning up

  - Package doctrine/orm (2.2.1)
    Downloading                                                                 
    Unpacking archive
    Cleaning up

  - Package doctrine/common (2.2.1)
    Downloading                                                                 
    Unpacking archive
    Cleaning up

  - Package symfony/symfony (dev-master)
    Cloning 294b57e1b15f28541444f667be5c98d90ab8c668

Writing lock file
Generating autoload files
[avocado: DoctrineBundle] master $ phpunit 
PHPUnit 3.6.5 by Sebastian Bergmann.

Configuration read from /home/jmikola/workspace/DoctrineBundle/phpunit.xml.dist

................................................................. 65 / 86 ( 75%)
.....................

Time: 1 second, Memory: 69.00Mb

OK (86 tests, 382 assertions)

One problem I noticed is that ``--install-suggestsdoesn't installdoctrine/orm` despite it being listed as a suggested dep in `composer.json`. I had to move the package into the "require" block to actually get the dependency. Without ORM installed, the test suite fails hard:

[avocado: DoctrineBundle] master $ phpunit 
PHPUnit 3.6.5 by Sebastian Bergmann.

Configuration read from /home/jmikola/workspace/DoctrineBundle/phpunit.xml.dist

.EE.............................................................. 65 / 86 ( 75%)
........PHP Fatal error:  Class 'Doctrine\ORM\Mapping\ClassMetadataInfo' not found in /home/jmikola/workspace/DoctrineBundle/Tests/Mapping/MetadataFactoryTest.php on line 23

Fatal error: Class 'Doctrine\ORM\Mapping\ClassMetadataInfo' not found in /home/jmikola/workspace/DoctrineBundle/Tests/Mapping/MetadataFactoryTest.php on line 23

[schmittjoh]

Maybe it's just travisci that fails?

http://travis-ci.org/#!/doctrine/DoctrineBundle/jobs/799379

[jmikola]

Woah, it looks like I was testing my own outdated fork. Fixing.

[schmittjoh]

Thanks!

[jmikola]

Thanks for catching this. I wasn't aware the bundle was set up for Travis CI - I just enabled it on my fork so this shouldn't happen again :)