Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug log should include connection name #43

Closed
igorw opened this issue Mar 23, 2012 · 3 comments
Closed

Debug log should include connection name #43

igorw opened this issue Mar 23, 2012 · 3 comments
Labels

Comments

@igorw
Copy link
Contributor

igorw commented Mar 23, 2012

When working with multiple connections, it would be really useful if the log entry would include the connection name.

@dlsniper
Copy link
Contributor

AFAICT the log message comes directly from Doctrine DBAL so maybe that's the thing I should look for to patch.

Also it seems that the Profiler from Symfony2 already contains the info that you need so is this still needed or the issue can be closed?

@igorw
Copy link
Contributor Author

igorw commented Mar 31, 2012

I see the ambiguity now. This ticket was not about the profiler, but the monolog logging.

@ostrolucky
Copy link
Member

This is oldest issue we have here without any feedback, for which I'm sorry. Unfortunately this doesn't seem concrete enough proposal and more discussion would be required about changing our logging messages in general, as currently format is simple {query} [{queryParameters}]. I don't see there good position where to put connection name. Ideally it would be in parameters, but currently it's reserved for query parameters. And putting it before or after query might be problematic for future extensions, as people will start requesting adding more and more information to display there. If there is demand for this, message format should be revamped in more general manner, so people can customize it more. Let us know in new issue if there is some interest for this, ideally with more concrete proposal. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants