-
Notifications
You must be signed in to change notification settings - Fork 85
LiipDoctrineCacheBundle #1
Comments
I wonder if
|
i am generally open to move it to the Doctrine org .. we created it out of a need .. but we have no need to keep it in our namespace just for marketing. so if it makes it easier and more trustworthy for people to have it hear .. we are good with that. also it will likely make it easier to ensure the right people have access. |
@lsmith77 we missed it. I didn't recall about LiipCacheBundle when we exchange emails internally (actually, none responded Fabio's emails internally). Now let's see what can we do:
Internally, we'd like to have Doctrine organizational support for a cache controlling as a Bundle. Would like to hear from @doctrine/team-doctrine2 and @doctrine/team-symfony-integration too. Our ultimate goal is to heavily simplify Symfony\Bridge\Doctrine support. |
I would vote for 4) because then users of |
The good news is that for people to migrate to this Bundle all that should be necessary would be changing a 1) dependency, 2) their app kernel and 3) some configuration. 1) and 2) are unavoidable but 3) should ideally be kept to a minimum. Once this Bundle is stable and provides the same features I would then deprecate Liip's Bundle. BTW: There is a website called knpbundles.com that makes it easy to know if there is a bundle before writing a new one ;) |
wtf sorry I clicked the wrong button :( can anyone reopen please? |
ah found it :D sorry. What I wanted to say is that I think deprecating the "old" bundle should be the way to go. |
@lsmith77 I evaluated the features available as part of LiipDoctrineCacheBundle. Related to provider specific configuration is where we diverge. We created a schema for each driver as an specific definition, which forced users to have something like this: doctrine_cache:
providers:
foo:
type: 'file_system'
file_system:
extension: 'phpc'
directory: "%kernel.cache_dir%/configurable-phpfile-provider" Compared to LiiipDoctrineCacheBundle: liip_doctrine_cache:
namespaces:
foo:
type: 'file_system'
extension: 'phpc'
directory: "%kernel.cache_dir%/configurable-phpfile-provider" Trying to converge LiipDoctrineCacheBundle supports aliases. We should support this too, will open a ticket for this. Service name change. People would be force to change Custom cache types is something we haven't planned and surely we need to allow this too. WIll open another ticket for this support. Besides these things, there's nothing else missing. Or am I wrong? |
voting for 2 (Move Liip's to Doctrine organization and remove this one) and implementing the good suggestions as PR on Liip's one. |
imo 2 is best thing to do for now ... |
I think #2 seems the most sensible option, no one uses this bundle yet so it makes sense to move the currently more popular Liip bundle to this one |
I'm in favor of option 4.
Facing from a different direction (Liip being moved), we would have to write tests and also a BC break to allow proper XML schema and driver specific properties. Also, this bundle only got published after it got tested in production at @instaclick. |
The goal of this bundle is to replace/reduce the cache logic inside doctrine/bridge. Is probably my mistake not evaluating liip before i start to work in this one. I think we should go with option |
Let's consider this ticket closed then. =) |
Besides custom cache providers, all other features have already been implemented in master. =) |
I assume you are aware of https://github.com/liip/LiipDoctrineCacheBundle ?
The text was updated successfully, but these errors were encountered: