-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Back Meaningful Message When "latest" Version Already Reached #987
Comments
It is not a BC break, console messages are not covered by BC promise |
Agreed, it was more for convenience! Up to you to decide ! |
@goetas but why it's now ERROR (not WARNING)? it breaks our ci. |
yes |
Console messages not, but this is not only message text change but also exist code. In my opinion, however, this is a change worth at least adding to the changelog. |
The message is not only misleading, it is wrong too. The latest version was reached without error! It Just did not happen during this run. There is no need to alarm the user about it. |
#988 has been merged |
So I'm closing this. I see that multiple people are disagreeing with the current implementation, this are the possibilities:
|
Thanks @goetas 🍻 |
Related to this conversation : #1012 (comment) |
[ERROR] The version "latest" couldn't be reached, you are at version "0"
|
See #1015, that should make this behavior compatible with the previous 2.x version |
@BonBonSlick please avoid posting questions not related to this ticket. If you have questions please open a dedicated ticket. |
@goetas why it was not related? I found solution, after composer update config file messed
|
@BonBonSlick this ticket was about that message being displayed when there are no other migrations to execute (but migrations were loaded correctly), and that is what #988 solved. |
Bug Report
Summary
When launching a migration on a fully migrated platform (i.e. on "latest" version), the message changed from 3.0.0-alpha1 to 3.0.0-beta1/stable.
Before we had a nice and clean
"[WARNING] Already at latest version"
which was perfect.Now we have
"[ERROR] The version "latest" couldn't be reached, you are at version xxx"
which surprised a bit our developer community.We provide a Pull Request in order to get back the more meaningful message. It would be great if you guys could have a look at it and maybe integrate it 😄.
It might look like a detail but we feel that providing nice and meaningful is essential. It seems that the message change happened in this commit. It is just a "loss" we would like to see back again.
Current behavior
When a platform is at "latest" version, launching a new migration produces the following output:
How to reproduce
Launch a successful migration process, then run it again.
Expected behavior
When a platform is at "latest" version, launching a new migration produce the following output:
The text was updated successfully, but these errors were encountered: