Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #41 #42

Closed
wants to merge 3 commits into from
Closed

Fix #41 #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d916f7
Fix #41
Aug 3, 2011
5d3b0dd
Add space and else some line
Aug 3, 2011
8e73844
Add space and else some line
Aug 3, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/Doctrine/DBAL/Migrations/Tools/Console/Command/DiffCommand.php
View file
Open in desktop
Expand Up @@ -99,8 +99,13 @@ private function buildCodeFromSql(Configuration $configuration, array $sql)
if (strpos($query, $configuration->getMigrationsTableName()) !== false) {
continue;
}
$code[] = "\$this->addSql(\"$query\");";
$codeSql[] = "\$this->addSql(\"$query\");";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is $codeSql instantiated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please initialize the $codeSQL Variable and check for count() instead of isset()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd check !empty($codeSQL)

}

if (isset($codeSql)) {
return implode("\n", array_merge($code, $codeSql));
} else {
return;
}
return implode("\n", $code);
}
}