Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Fix skipped tests #1791

Closed
alcaeus opened this issue May 13, 2018 · 3 comments
Closed

[2.0] Fix skipped tests #1791

alcaeus opened this issue May 13, 2018 · 3 comments
Assignees
Projects
Milestone

Comments

@alcaeus
Copy link
Member

alcaeus commented May 13, 2018

As evidenced in the master build, there are a bunch of skipped tests: https://travis-ci.org/doctrine/mongodb-odm/jobs/376653436#L1607. Some of these relate to sharding support, others (e.g. SchemaManagerTest) needs to be refactored.

@alcaeus alcaeus added the Task label May 13, 2018
@alcaeus alcaeus added this to the 2.0.0 milestone May 13, 2018
@alcaeus alcaeus added this to To Do in ODM 2.0 via automation May 13, 2018
@caciobanu
Copy link
Contributor

Wanted to give $this->markTestSkipped('mongodb-driver: query logging does not exist'); a try but not sure how to fix it. We should delete the tests or the feature has to be implemented ?

@alcaeus
Copy link
Member Author

alcaeus commented Aug 10, 2018

So, these tests used to inject a custom logger into the LoggableCollection and LoggableDatabase classes to track every command that was run. We've decided to drop these classes in favour of more mature tools. I'll have to think of a way to trace these.

For now, the only solution would be rewriting the tests to not require logging (where possible).

@alcaeus alcaeus added the Has PR label Nov 26, 2018
@alcaeus alcaeus self-assigned this Nov 26, 2018
ODM 2.0 automation moved this from To Do to Done Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
ODM 2.0
  
Done
Development

No branches or pull requests

2 participants