Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation on Events and @HasLifecycleCallbacks annotation #726

Closed
dao opened this issue Dec 21, 2013 · 4 comments
Closed

documentation on Events and @HasLifecycleCallbacks annotation #726

dao opened this issue Dec 21, 2013 · 4 comments
Labels

Comments

@dao
Copy link
Contributor

dao commented Dec 21, 2013

docs/en/reference/events.rst claims that @HasLifecycleCallbacks annotation is required to indicate that a Document has .. lifecycle callbacks. I grepped "HasLifecycleCallbacks" in my vendors directory and only got results from ORM.

Is this annotation actually necessary?

@jmikola
Copy link
Member

jmikola commented Jan 1, 2014

This is related to #428. @HasLifecycleCallbacks was removed and we were discussing adding it back, as there were issues with method annotations triggering twice within inheritance hierarchies. I'll try to get that issue resolved soon.

@bmeynell
Copy link

Can we use lifecycle callbacks in ODM without this?

@gui-com-pt
Copy link

@bmeynell yes, you can

@jmikola
Copy link
Member

jmikola commented May 6, 2014

@dao: #428 was resolved, so I think this can be closed.

I believe there might have been some confusion since the docs were published from master before the release itself was tagged.

@bmeynell and @guilhermegeek: The @HasLifecycleCallbacks annotation is required for lifecycle callbacks as of BETA10. See the changelog for a more detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants