Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-3437: [GH-1213] fix instantiation of embedded object in ReflectionEmbeddedProperty #4244

Closed
doctrinebot opened this issue Dec 6, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of austinsmorris:

Url: #1213

Message:

Recently, ReflectionEmbeddedProperty was updated to extend ReflectionProperty. This broke any embeddable that extends an abstract class. That's because if a property is defined in the abstract class, $this->class is alway the abstract class and thus cannot be instantiated. The $class parameter that is passed into the constructor needs to be stored, and that class should be instantiated, not the the property's declaring class.

@doctrinebot
Copy link
Author

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1213] was assigned:
#1213

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1213] was closed:
#1213

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.5 milestone Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants