Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-3761: Entity Cache Key save bug #4602

Closed
doctrinebot opened this issue Jun 8, 2015 · 5 comments
Closed

DDC-3761: Entity Cache Key save bug #4602

doctrinebot opened this issue Jun 8, 2015 · 5 comments
Assignees

Comments

@doctrinebot
Copy link

Jira issue originally created by user Mark.Ragazzo:

When using memcached for caching query or entities, queries will be performed each time, since EntityCacheKey use space in its key. I can submit PR if needed. Let me know if it is needed to be fixed in other places, however i looked through the code and have not found any other places

@doctrinebot
Copy link
Author

Comment created by Mark.Ragazzo:

any news on this one? Should i submit PR or is there any internals issues?

@doctrinebot
Copy link
Author

Comment created by @FabioBatSilva:

That seems to be the issue,
Please fell free to send a PR

@doctrinebot
Copy link
Author

Comment created by Mark.Ragazzo:

fixed it with simple replacing spaces to dots, in this PR #1423. We already use this in production with Second Level Cache, however we replaced whole key with md5() for simplicity. Also it may not be question for you but why there is no checks for key length for cache? Since default policy for SCL is to rely on namespaces when generate keys it can easily go out of 250 bytes for memcached, since it invoke a lot of prefixing and so on.

@doctrinebot
Copy link
Author

@lcobucci
Copy link
Member

Closing as invalid since it should be solved on the memcache(d) provider in doctrine/cache.

@lcobucci lcobucci self-assigned this Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants