Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Tool: Ignore some database fields #6434

Open
mpdude opened this Issue May 10, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@mpdude
Copy link
Contributor

mpdude commented May 10, 2017

When working with legacy databases, I often have some columns in the database that have no corresponding field in the entity class (for various reasons probably not relevant here).

This makes the schema tool almost useless as it always tries to drop or otherwise change these columns. You'll always have to carefully cherry-pick the "real" changes.

I know that the schema tool can be configured to ignore certain tables, but that does (to my knowledge) not work on the field level.

So, my idea was to add entity configuration meta-data to denote these "ignored" fields. But as I am writing this, adding something like the FilterSchemaAssetsExpression in \Doctrine\DBAL\Configuration for the field level seems like another possible solution (yes, that's another repo).

What do lead devs think? Would you support such a PR?

@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented May 10, 2017

@mpdude I had this scenario multiple times, but this drags in an additional family of problems, as this would then leak also to FKs, constraints, indexes, sequences.

Not sure we want to dig into this rabbit hole, but you can try. What would you imagine the filters to look like?

@mpdude

This comment has been minimized.

Copy link
Contributor Author

mpdude commented May 10, 2017

Oh, good point!

If it were a config setting in the DBAL layer, simply pretending that the fields would not be there – are FKs, indexes etc. an issue at all?

Sure, if you get this config wrong by hiding a field that is actually needed, you might be surprised why the schema tool tries to add it. But, either way, chances are somebody gets hurt.

As to how filters could look like, I probably don't get the point... Maybe a regex? :-)

@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented May 10, 2017

Maybe a regex? :-)

Callback?

@dbu

This comment has been minimized.

Copy link
Member

dbu commented Feb 26, 2019

Note that it is possible to make the Doctrine Schema tool not see database fields with the onSchemaColumnDefinition event, and also for indexes with onSchemaIndexDefinition.

I wrote a blogpost with code examples: https://www.liip.ch/en/blog/doctrine-and-generated-columns

The listener is rather heavy though, so an explicit configuration would be easier to understand and involve less effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.