Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free document sending limitation bypass #883

Closed
6 tasks done
ashrafchowdury opened this issue Jan 30, 2024 · 4 comments · Fixed by #898
Closed
6 tasks done

Free document sending limitation bypass #883

ashrafchowdury opened this issue Jan 30, 2024 · 4 comments · Fixed by #898
Assignees
Labels
apps: web Issues related to the webapp status: assigned Issue has been assigned type: bug Something isn't working

Comments

@ashrafchowdury
Copy link
Contributor

Issue Description

I exactly don't know whether it's bug or a feature. The application fails to enforce the restriction on sending only 5 free documents per month effectively. Users can bypass this limitation by creating new templates and sending documents through them, without encountering any restrictions regarding their usage quota.

Despite reaching the 5-document limit, the application allows the user to continue sending additional documents throw templates without any restriction.

Steps to Reproduce

  1. Log in to the application
  2. Crose the limitation of sending 5 documents in the free tire.
  3. Then go to the templates page.
  4. Create a new template.
  5. Send the template document to signers.
  6. Then if you want you can delete the template
  7. Notice that the application does not display any warnings, errors, or notifications regarding exceeding the free document limit.

Expected Behavior

The application should enforce the limitation on sending only 5 free documents including template documents also per month per user.

Current Behavior

The application fails to enforce the free document limitation effectively. Users can easily bypass the restriction by creating new templates and sending documents through them without encountering any restrictions regarding their usage quota.

Screenshots (optional)

documenso_document_limitation_bug.-.Made.with.Clipchamp.mp4

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome, Edge

Version [e.g., 2.0.1]

Latest

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@ashrafchowdury ashrafchowdury added the type: bug Something isn't working label Jan 30, 2024
@maige-app maige-app bot added priority: high High priority issue Business needs-replication Looking for users to replicate the issue labels Jan 30, 2024
@github-actions github-actions bot added the status: triage Scope to be determined label Jan 30, 2024
@ashrafchowdury
Copy link
Contributor Author

I would like to work on this issue if it gets approved.

@dguyen dguyen added status: assigned Issue has been assigned apps: web Issues related to the webapp and removed priority: high High priority issue Business status: triage Scope to be determined needs-replication Looking for users to replicate the issue labels Jan 30, 2024
@dguyen
Copy link
Collaborator

dguyen commented Jan 30, 2024

Thanks @ashrafchowdury! I've assigned it to you :)

@ashrafchowdury
Copy link
Contributor Author

Hay @dguyen,

To prevent exceeding the limit, I added a server condition that verifies before creating a new document from templates. Additionally, we will disable the 'Use Template' button on the frontend.

When the 'Use Template' button becomes disabled after reaching the limit, users are not informed of the reason for it. To address this issue, we can add an Alert component to notify the user.

Here is the demo:
image

@dguyen
Copy link
Collaborator

dguyen commented Jan 31, 2024

Hey @ashrafchowdury, could you please create a PR so we can have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp status: assigned Issue has been assigned type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants