Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n to documenso #885

Open
4 of 6 tasks
NilsJacobsen opened this issue Jan 30, 2024 · 13 comments
Open
4 of 6 tasks

Add i18n to documenso #885

NilsJacobsen opened this issue Jan 30, 2024 · 13 comments
Labels
status: triage Scope to be determined type: enhancement Enhancing a existing feature type: feature New feature or request

Comments

@NilsJacobsen
Copy link

NilsJacobsen commented Jan 30, 2024

Feature Description

I heard that some people have already discussed localizing Documenso. As a member of the inlang core team, I can share my knowledge if you're interested.

Use Case

For better expansion, i18n might be beneficial for documenso.

Proposed Solution

If I would start localizing today, I would go for ParaglideJS. It might be the best-performing i18n lib -> hype video

I would also integrate some kind of quality with CI jobs. Check out CLI Lint and Lint Rules.

If you have translators, you can use the localization editor and as a developer you can use the ide extension.

But this is all opt-in, you just add a configuration file, so if you want, go with json.

-> If you want help with the initial setup, let me know.

Please check the boxes that apply to this feature request.

  • I have searched the existing feature requests to make sure this is not a duplicate.
  • I have provided a detailed description of the requested feature.
  • I have explained the use case or scenario for this feature.
  • I have included any relevant technical details or design suggestions.
  • I understand that this is a suggestion and that there is no guarantee of implementation.
  • I want to work on creating a PR for this issue if approved
@maige-app maige-app bot added type: enhancement Enhancing a existing feature help wanted Extra attention is needed type: feature New feature or request status: triage Scope to be determined labels Jan 30, 2024
Copy link

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@anikdhabal
Copy link
Contributor

anikdhabal commented Jan 30, 2024

Pls assign this to me. Actually, I've started working on it a while ago, hopefully, I'll make a pull request soon.

@NilsJacobsen
Copy link
Author

@anikdhabal which i18n stack are you using?:)

@anikdhabal
Copy link
Contributor

@anikdhabal which i18n stack are you using?:)

Hey I am using next-i18next.

@NilsJacobsen
Copy link
Author

How far are you in the process? Did you look into ParaglideJS?

@kodermax
Copy link

@NilsJacobsen will this library allow you to switch between languages without changing the url to /de/en?

@NilsJacobsen
Copy link
Author

I'm not really sure what you mean @kodermax. For sure you can also use a cookie strategy for i18n. If you discovered a big can you please open an issue https://github.com/opral/monorepo/issues.

@ElTimuro ElTimuro removed the help wanted Extra attention is needed label Apr 10, 2024
@NilsJacobsen
Copy link
Author

Hey folks, how far along are you with the i18n implementation?

@ElTimuro
Copy link
Member

  • @NilsJacobsen so far didn't start, since there was a lot other other priorities
  • We are open to looks at suggestions, though

@NilsJacobsen
Copy link
Author

Which parts of the repo are planned to be localized? I guess the nextjs apps right?

Then I recommend paraglide-next. It's also recommended by nextjs -> https://nextjs.org/docs/app/building-your-application/routing/internationalization#resources (mentioned as inlang)

@ElTimuro
Copy link
Member

Yes the apps (website, webapp and docs eventually)

@NilsJacobsen
Copy link
Author

You can ping me when you kickoff the project.

@opiredev
Copy link

opiredev commented May 2, 2024

@nabby27 created a $20.00 reward using Opire

How to earn this reward?

Since this project does not have Opire bot installed yet 😞 you need to go to Opire and claim the rewards through your programmer's dashboard once you have your PR ready 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage Scope to be determined type: enhancement Enhancing a existing feature type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants