Issue with listenTo/stopListening and context

[tgriesser]

@kpdecker brought up this issue on #1954 - stopListening won't work with more than one context. Since the context isn't stored alongside the _listenerId, listening to the same object with two contexts makes it impossible to call stopListening and have all of the listeners properly removed.

test("bulk stopListening with context", 4, function() {
      var a = _.extend({}, Backbone.Events);
      var b = _.extend({}, Backbone.Events);
      var ctx = {};
      var calledWithContext = false;
      var calledWithoutContext = false;

      a.listenTo(b, 'foo', function(){ calledWithContext = true; }, ctx);
      a.listenTo(b, 'foo', function(){ calledWithoutContext = true; });

      a.stopListening(null, null, null, ctx);

      b.trigger('foo');

      equal(calledWithContext, false);
      equal(calledWithoutContext, true);

      calledWithContext = false;
      calledWithoutContext = false;
      a.stopListening();

      b.trigger('foo');

      equal(calledWithContext, false);
      equal(calledWithoutContext, false);
});

[caseywebdev]

The cleanest solution would be to remove the context option again. Otherwise, we have to do housekeeping on all of the passed in contexts...

objA.listenTo(objB, name, method, objC); still looks weird to me, like objA isn't really listening to anything, it's merely mediating objC's listenTo.

[gsamokovarov]

👍 I liked the implicit this context better. Plus, it just makes the stopListening job way more cleaner and you can always _.bind another context, if you really have to.

[tgriesser]

I agree with @caseywebdev and @gsamokovarov

[braddunbar]

Ditto. The context argument makes little sense to me.

On Monday, December 24, 2012, Tim Griesser wrote:

I agree with @caseywebdev https://github.com/caseywebdev and
@gsamokovarov https://github.com/gsamokovarov

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2015#issuecomment-11665192.

-brad

[jashkenas]

Lovely.