support for ender.js

[dvv]

Please, consider applying.
TIA,
--Vladimir

[jashkenas]

Compatibility with Ender.js is usually defined on the Ender side of things, and not the libraries Ender targets. Just being a CommonJS-compliant module should be good enough for this.

[dvv]

Do I get this right that you say any library which provides or will provide the basis for backbone must implement $.browser.msie, jQuery or Zepto and _?

[jashkenas]

Sorry, didn't look at the commit closely enough -- you're quite right.

[jashkenas]

Thanks, merged to master with some implementation tweaks at: 4070364

[dvv]

Thanks

[dvv]

Am sorry, in my code I didn't use Backbone.sync, but we need to normalize $.ajax. I see the following differencies:
jQuery.ajax: .type is verb, .dataType is expected format, no .headers
ender.ajax: .method is verb, .type is expected format, .headers (no "before" hooks), no .contentType (.headers should do)

[samuelclay]

I'm pulling out Ender.js support for the time being until the signatures of the ajax methods are normalized to what jQuery and Zepto use. There are also other areas where Ender needs to be tested with Backbone. It's not fully baked support yet, so it's better if we remove the Ender reference until the tests are in. Removed in 1d4484d

[dvv]

np. i pinged ender.js guys a couple of days ago -- they added before to mimick onbeforesend hook. What about further normalization (completely different meaning to type options key) -- i think it's to be done in Backbone.sync.

[dvv]

@samuelclay: can you at least leave var $ = root.jQuery ... || root.$? This won't harm existing stuff, still will allow to use custom $s. TIA

[ded]

argh. stupid jQuery signature is wrong. type should be the data type, not the method -- we'll see what we can do on Reqwest side.

[benekastah]

@ded What's the status of reqwest on this? Is there a clear path as far as the changes that should be made to reqwest? I would be happy to issue a pull request for whatever those changes are, if a decision can be made.

[rvagg]

Reqwest 0.4.0 brings a compat mode so Ender can now speak the strange alien language of jQuery/Zepto.

$.ajax.compat({
  url: 'path/to/data.json?foo=bar',
  dataType: 'json',
  contentType: 'application/json',
  success: function() {
    // whatever
  }
});

or to install this as the default mode then put this at the top of your code somewhere:

$.ajax.compat && $.ender({ ajax: $.ajax.compat });

See the readme or source for gory details.

A Backbone user may want to confirm that all is well in the Backbone/Ender love nest?

For best compatibility it may be good to do this in Backbone.sync():

    return ($.ajax.compat || $.ajax)(_.extend(params, options));

or, better still create a reference to it at init so it's not checked each time:

  var $ = root.jQuery || root.Zepto || root.ender;
  var $ajax = $.ender && $.ajax && $.ajax.compat ? $.ajax.compat : $.ajax;

and use $ajax in Backbone.sync().