Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Viewer translation #121

Open
kgshv opened this issue Aug 8, 2014 · 6 comments
Open

Viewer translation #121

kgshv opened this issue Aug 8, 2014 · 6 comments

Comments

@kgshv
Copy link

kgshv commented Aug 8, 2014

The viewer language defaults to English on any embeds, even if the organization language is set to Russian or Ukrainian. If viewer is opened from within the workspace, it's in the language the workspace is but it defaults to English on embeds.

As far as I know this is an issue with viewer not getting language data from the servers on initiation. I suggest default the viewer language to document language instead of the org language, I kind of feel this way we could pass the language info more easily, but that's IMHO.

@reefdog reefdog changed the title Viwer translation Viewer translation Apr 28, 2015
@reefdog
Copy link
Contributor

reefdog commented Apr 28, 2015

@roloyar This is something we hope to add this year. Naturally we'd want to let readers change the language within the embed chrome, but as you say, choosing the default is tough. What's a more likely proxy for the reader's language: the organization/publisher, or the document content?

My gut says the former, because a Russian-language organization is likely to be publishing for Russian-language readers. But there's a significant argument for the latter: that if the reader is expected to be able to read the embedded document in a given language, then the viewer interface can safely reflect that.

We may need to survey some of our non-English organizations to get their input. @roloyar: Your vote is for defaulting to the document language?

@knowtheory
Copy link
Member

Just to summarize the things i've discussed with @roloyar and @nathanstitt in the past, the stance i've taken is as follows:

News organizations publish in a particular language. That should be previously specified, and so it should be sane to ask them to identify the display language for the viewer as embedded on their properties.

In the event that an org publishes in multiple languages (Say the CBC, which publishes in both french and english) we perhaps do want people to be able to specify on a per document case what the display language for the viewer is.

Also, it is absolutely the case that we do not want to default to document language. There are many circumstances under-which an organization may publish a document that is not in the language of their publication (english documents on a ukrainian site, or Chinese documents posted on an African news org's site, etc).

@kgshv
Copy link
Author

kgshv commented Apr 28, 2015

@reefdog, @knowtheory is actually right and I agree with him on this. The bilingual approach also applies to Ukraine, also to such countries as Belarus, Kazakhstan, Georgia, etc., in all of which the population knows Russian to an extent that there are Russian-language media, which also publish content in country's official language.

I believe that there should be an account-wide default viewer language setting, which could be overwritten per viewer embed if needed.

@reefdog
Copy link
Contributor

reefdog commented Apr 28, 2015

Yup, that all sounds sensible. So a landscape like this then:

  1. Default language of embedded viewers (defined at org level)
  2. Custom language of embedded viewer (defined on document)
  3. Custom language of embedded viewer (defined by reader, saved as cookie)

@reefdog
Copy link
Contributor

reefdog commented May 6, 2015

This is definitely on the roadmap. Moving to document-viewer repo: documentcloud/document-viewer#54

@reefdog reefdog closed this as completed May 6, 2015
@knowtheory
Copy link
Member

Reopening this as tracking ticket (cause we're trying out huboard)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants