-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set_oauth_host_name function contain code that will never execute. #137
Comments
I work in developer support at DocuSign, and as I recall our customers used to be confused by setting this up in demo, missing the step of setting the oauth host, and ending up with the oath request being sent to production. That is the why we raise an error now instead of setting a default value. I have posted a bug to cleanup the unexecuted code. |
This bug is filed as [DCM-7258] Unexecuted Code in python API client. |
There is an internal method that is still expecting this empty call to implicitly define the oauth server. Silently defaulting to production is bad, but it can be fixed without discarding the convenience. The underlying problem with the original code was that the A slightly related topic: The way
The first 2 methods that require the positional arg can't be fixed without a major version bump (or 2 depending up your deprecation policies). I'm not sure what the maintainers' stance will be on set-then-call, optional-kwarg, or required-arg, but I would recommend settling on one and make sure all the methods use that pattern in the next (few?) major release(s?). |
docusign-esign-python-client/docusign_esign/client/api_client.py
Line 810 in 330a500
Correct me if I'm wrong, but this code will never execute.
I would like to use this functionality :(
It's not a blocker or any critical bug, because I can pass oauth_host_name to ApiClient constructor.
Just letting you know this code looks strange.
The text was updated successfully, but these errors were encountered: