Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check and set refresh_token in body of request #61

Merged
merged 1 commit into from Mar 21, 2018
Merged

check and set refresh_token in body of request #61

merged 1 commit into from Mar 21, 2018

Conversation

psytester
Copy link
Contributor

I'm surprised that I'm the first one how is playing with refresh tokens on that method call

  1. the body never got the refresh_token set as the related code was missing
  2. a better/detailed check was added, that if grant_type=refresh_token it requires a refresh_token

I'm surprised that I'm the first one how is playing with refresh tokens on that method call
1. the body never got the refresh_token set as the related code was missing
2. a better/detailed check was added, that if grant_type=refresh_token it requires a refresh_token
Copy link
Contributor

@mmallis87 mmallis87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmallis87 mmallis87 merged commit 59f5c92 into docusign:master Mar 21, 2018
@psytester psytester deleted the patch-5 branch March 23, 2018 20:13
mmallis87 added a commit that referenced this pull request Aug 29, 2019
check and set refresh_token in body of request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants