invokeAPI populate response object in ApiException for non successful… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTTP codes This PR is for the issue #68 request to populate the response in ApiException object for non successful HTTP codes. With that change the client code can process on it.
mmallis87
suggested changes
Apr 20, 2018
| @@ -766,7 +766,13 @@ private ClientResponse getAPIResponse(String path, String method, List<Pair> que | |||
| ClientResponse response = getAPIResponse(path, method, queryParams, body, headerParams, formParams, accept, contentType, authNames); | |||
|
|
|||
| if (response.getStatusInfo().getFamily() != Family.SUCCESSFUL) { | |||
| throw new ApiException("Error while requesting server, received HTTP code: " + response.getStatusInfo().getStatusCode() + " / with response Body: " + response.getEntity(String.class)); | |||
| String respBody = null; | |||
There was a problem hiding this comment.
@psytester can you change it to: String respBody = response.getEntity(String.class);
mmallis87
added a commit
that referenced
this pull request
Aug 29, 2019
invokeAPI populate response object in ApiException for non successful…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… HTTP codes
This PR is for the issue #68 request to populate the response in ApiException object for non successful HTTP codes.
With that change the client code can process on it.