Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example does not work out of the box: wrong API calls #6

Closed
mariobig opened this issue Dec 5, 2019 · 6 comments
Closed

Example does not work out of the box: wrong API calls #6

mariobig opened this issue Dec 5, 2019 · 6 comments
Labels
DEVDOCS-1710 question Further information is requested responded

Comments

@mariobig
Copy link

mariobig commented Dec 5, 2019

There are plenty of errors in the published code.
For example:

everywhere:
$envelope_api = new \DocuSign\eSign\Api\EnvelopesApi($api_client);

should be:
$envelope_api = new \DocuSign\eSign\Client\Api\EnvelopesApi($api_client);

@InbarGazit
Copy link
Member

@mariobig can you tell me which version of the SDK and the API you are using?

@mariobig
Copy link
Author

mariobig commented Dec 5, 2019

Hi ,

I followed step by step installation instruction published at https://github.com/docusign/eg-03-php-auth-code-grant.

Mario

@InbarGazit
Copy link
Member

I understand, but can you still try to find the versions and let us know?

@mariobig
Copy link
Author

mariobig commented Dec 6, 2019

In my opinion it has nothing to do with versions of SDK or API. Official DocuSign SDK is correct and up to date.

Simply, the code itself published here in examples contains a lot of bugs:

Examples:
src/EG001EmbeddedSigning.php
line 109: $api_client = new \DocuSign\eSign\ApiClient($config);
should be: $api_client = new \DocuSign\eSign\Client\ApiClient($config);

src/EG002SigningViaEmail.php
line 109: $api_client = new \DocuSign\eSign\ApiClient($config);
should be: $api_client = new \DocuSign\eSign\Client\ApiClient($config);

src/EG008CreateTemplate.php
line 94: $api_client = new \DocuSign\eSign\ApiClient($config);
should be: $api_client = new \DocuSign\eSign\Client\ApiClient($config);

src/EG003ListEnvelopes.php: does not work
src/EG006ListEnvelopes.php: does not work
src/EG007ListEnvelopes.php: does not work (same bug like in EG001EmbeddedSigning.php and src/EG002SigningViaEmail.php)
src/EG009ListEnvelopes.php: does not work beacuse example 8 does not return template ID
src/EG016ListEnvelopes.php: does not work (line 112 same bug like in EG001EmbeddedSigning.php and src/EG002SigningViaEmail.php)
src/EG018ListEnvelopes.php: does not work (same bug like in EG001EmbeddedSigning.php and src/EG002SigningViaEmail.php and others bugs as well)
src/EG019ListEnvelopes.php: does not work (error in eg-03-php-auth/vendor/twig/twig/src/Loader/FilesystemLoader.php on line 250)

@LarryKlugerDS
Copy link
Contributor

Thank you @mariobig for the bug report. You're correct, the example should work properly out of the box.

I have filed bug DEVDOCS-1710

@LarryKlugerDS LarryKlugerDS added question Further information is requested DEVDOCS-1710 responded labels Jan 2, 2020
@LarryKlugerDS LarryKlugerDS changed the title wrong call for api Example does not work out of the box: wrong API calls Mar 18, 2020
@AaronWDS
Copy link
Contributor

karissarjacobsen added a commit that referenced this issue Dec 7, 2020
* update JWT scope issues and README documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEVDOCS-1710 question Further information is requested responded
Projects
None yet
Development

No branches or pull requests

4 participants