New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering joins, tests #59
Conversation
I've since added gather() from tidyr. Technically not dplyr, but the tidyr package (it only has a few functions) may be nice to add, since it plays well with dplyr. |
gather doesn't seem to play well with python 2.7.9 so I need to fix that first. |
Hey-- do you want to split this out into two pull requests? One request to add I agree with you that the main |
I think it's kind of weird that github keeps adding commits to the pull request. It seems to me like it should freeze the request for when it was made. |
I'm not an expert, but the methodology that I've been using that's worked well is what you describe. I keep all pull requests, and really any modular work like a new feature, in separate branches. I submit a pull request when that feature is ready, and only commit to that branch if I need to update something for the PR. |
@bleearmstrong, the common practice regarding
A |
Thank you @has2k1, that makes sense when you explain it like that. |
semi_join() and anti_join() are now functional, and there is a fair bit of testing added for them.
One possibly minor note: they do require pandas v. 0.17.0 (current on v. 0.18.1). Not sure if this is too much to ask, but they do require it (specifically, it's an option that was added to pandas.DataFrame.merge).