Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddJsonClient doesn't respect clientName parameter #25

Closed
Ceridan opened this issue Apr 11, 2020 · 2 comments
Closed

AddJsonClient doesn't respect clientName parameter #25

Ceridan opened this issue Apr 11, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Ceridan
Copy link
Contributor

Ceridan commented Apr 11, 2020

AddJsonClient extension method provided by the library has clientName argument to create named clients but actually never use it.

Actually it is not a bug, it was never implemented. We should fix it.
@Ceridan Ceridan added the enhancement New feature or request label Apr 11, 2020
@NYMEZIDE
Copy link
Contributor

NYMEZIDE commented Oct 5, 2020 •
edited
Loading

take on the job

@NYMEZIDE NYMEZIDE mentioned this issue Oct 5, 2020
Merged
@Ceridan
Copy link
Contributor Author

Ceridan commented Oct 6, 2020

Closed in #35. Thanks to @NYMEZIDE

@Ceridan Ceridan closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ceridan @NYMEZIDE