Skip to content

Commit

Permalink
25112011
Browse files Browse the repository at this point in the history
- It is no more necessary to call -cleanUp on MFDocumentViewController before releasing it (check the README).
- MFHomeListPdf is now BookItemView, be careful if you are subclassing it.
- Faster page redrawn on re-layout (goToPage, setPageMode, etc).
- Minor memory managment improvements
  • Loading branch information
nick committed Nov 25, 2011
1 parent 65adb48 commit 8efbf8f
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 35 deletions.
8 changes: 1 addition & 7 deletions Classes/KioskApp/Controllers/BookItemView.m
Expand Up @@ -411,8 +411,6 @@ -(void)downloadPDF:(id)sender withUrl:(NSString *)sourceURL andName:(NSString *)

if (status2 && status1){

NSLog(@"download con NewsStand");

NKLibrary *library = [NKLibrary sharedLibrary];
if ([library issueWithName:namePdf]) {
[library removeIssue:[library issueWithName:namePdf]];
Expand All @@ -430,9 +428,6 @@ -(void)downloadPDF:(id)sender withUrl:(NSString *)sourceURL andName:(NSString *)

}else{


NSLog(@"download senza NewsStand");

NSURL *url = nil;
ASIHTTPRequest * request = nil;

Expand Down Expand Up @@ -639,7 +634,7 @@ - (void)connectionDidFinishDownloading:(NSURLConnection *)connection destination
} else {
suffix = @"pdf";
path = [path stringByAppendingPathComponent:[NSString stringWithFormat:@"%@.%@",filename,suffix]];
NSLog(@"path %@",path);

NSError *error = nil;
[[NSFileManager defaultManager] copyItemAtPath:[destinationURL path] toPath:path error:&error];
[[NSFileManager defaultManager] removeItemAtPath:[destinationURL path] error:&error];
Expand All @@ -651,7 +646,6 @@ - (void)connectionDidFinishDownloading:(NSURLConnection *)connection destination


- (BOOL)handleFPKFile {
NSLog(@"Alla fine del download FPK");

BOOL zipStatus = NO;

Expand Down
9 changes: 0 additions & 9 deletions FPKCore/MFDocumentViewController.h
Expand Up @@ -311,15 +311,6 @@
*/
-(void)moveToPreviousPage;

/**
Call this method rightly after dismissing this MFDocumentViewController
instance. It will release all the resources and stop the background threads.
Once this method has been called, the MFDocumentViewController instance cannot
be considered valid anymore and should be released.
*/
-(void)cleanUp;


/**
Convert a point from MFDocumentViewController's view space to page space.
*/
Expand Down
Binary file modified FPKCore/libFastPdfKit.a
Binary file not shown.
Binary file not shown.
Expand Up @@ -311,15 +311,6 @@
*/
-(void)moveToPreviousPage;

/**
Call this method rightly after dismissing this MFDocumentViewController
instance. It will release all the resources and stop the background threads.
Once this method has been called, the MFDocumentViewController instance cannot
be considered valid anymore and should be released.
*/
-(void)cleanUp;


/**
Convert a point from MFDocumentViewController's view space to page space.
*/
Expand Down
20 changes: 10 additions & 10 deletions FastPdfKit.xcodeproj/project.pbxproj
Expand Up @@ -55,10 +55,6 @@
01368077147E4D0E009E2DAA /* MFDocumentManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 01368074147E4D0E009E2DAA /* MFDocumentManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
01368078147E4D0E009E2DAA /* MFDocumentViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = 01368075147E4D0E009E2DAA /* MFDocumentViewController.h */; };
01368079147E4D0E009E2DAA /* MFDocumentViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = 01368075147E4D0E009E2DAA /* MFDocumentViewController.h */; settings = {ATTRIBUTES = (Public, ); }; };
01368081147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01368080147E82E7009E2DAA /* libFastPdfKit.a */; };
01368082147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01368080147E82E7009E2DAA /* libFastPdfKit.a */; };
01368083147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01368080147E82E7009E2DAA /* libFastPdfKit.a */; };
01368084147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01368080147E82E7009E2DAA /* libFastPdfKit.a */; };
014F442D14211E4B004FBEE9 /* img_overflow_pad.png in Resources */ = {isa = PBXBuildFile; fileRef = 014F442A14211E4A004FBEE9 /* img_overflow_pad.png */; };
014F442E14211E4B004FBEE9 /* img_overflow_phone.png in Resources */ = {isa = PBXBuildFile; fileRef = 014F442B14211E4A004FBEE9 /* img_overflow_phone.png */; };
014F442F14211E4B004FBEE9 /* img_overflow_phone@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = 014F442C14211E4B004FBEE9 /* img_overflow_phone@2x.png */; };
Expand Down Expand Up @@ -154,6 +150,10 @@
0161F22E141FAC24000EA8E4 /* OutlineViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0161F22C141FAC24000EA8E4 /* OutlineViewController.m */; };
0161F22F141FAC24000EA8E4 /* OutlineViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0161F22C141FAC24000EA8E4 /* OutlineViewController.m */; };
0161F230141FAC24000EA8E4 /* OutlineViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0161F22C141FAC24000EA8E4 /* OutlineViewController.m */; };
0164554A147FE90700A76F9F /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01645549147FE90700A76F9F /* libFastPdfKit.a */; };
0164554B147FE90700A76F9F /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01645549147FE90700A76F9F /* libFastPdfKit.a */; };
0164554C147FE90700A76F9F /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01645549147FE90700A76F9F /* libFastPdfKit.a */; };
0164554D147FE90700A76F9F /* libFastPdfKit.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 01645549147FE90700A76F9F /* libFastPdfKit.a */; };
0168707E1451B79400E9AE65 /* FPKOverlayViewDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0168707D1451B79400E9AE65 /* FPKOverlayViewDataSource.h */; };
0168707F1451B79400E9AE65 /* FPKOverlayViewDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0168707D1451B79400E9AE65 /* FPKOverlayViewDataSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
0174E2B012EF24CA003699A8 /* CoreText.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0174E2AF12EF24CA003699A8 /* CoreText.framework */; };
Expand Down Expand Up @@ -427,7 +427,6 @@
0134EE0C1456D9B2007D543F /* TVThumbnailScrollView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TVThumbnailScrollView.m; sourceTree = "<group>"; };
01368074147E4D0E009E2DAA /* MFDocumentManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MFDocumentManager.h; sourceTree = "<group>"; };
01368075147E4D0E009E2DAA /* MFDocumentViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MFDocumentViewController.h; sourceTree = "<group>"; };
01368080147E82E7009E2DAA /* libFastPdfKit.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libFastPdfKit.a; sourceTree = "<group>"; };
014F442A14211E4A004FBEE9 /* img_overflow_pad.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = img_overflow_pad.png; sourceTree = "<group>"; };
014F442B14211E4A004FBEE9 /* img_overflow_phone.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = img_overflow_phone.png; sourceTree = "<group>"; };
014F442C14211E4B004FBEE9 /* img_overflow_phone@2x.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "img_overflow_phone@2x.png"; sourceTree = "<group>"; };
Expand All @@ -444,6 +443,7 @@
016095DE14482814003CEAAA /* mfprofile.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = mfprofile.h; sourceTree = "<group>"; };
0161F228141FABE8000EA8E4 /* ReaderViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ReaderViewController.m; sourceTree = "<group>"; };
0161F22C141FAC24000EA8E4 /* OutlineViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OutlineViewController.m; sourceTree = "<group>"; };
01645549147FE90700A76F9F /* libFastPdfKit.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libFastPdfKit.a; sourceTree = "<group>"; };
0168707D1451B79400E9AE65 /* FPKOverlayViewDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FPKOverlayViewDataSource.h; sourceTree = "<group>"; };
0174E2AF12EF24CA003699A8 /* CoreText.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreText.framework; path = System/Library/Frameworks/CoreText.framework; sourceTree = SDKROOT; };
018848E7131E89570045038F /* FastPdfKit Kiosk.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "FastPdfKit Kiosk.app"; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -652,7 +652,7 @@
buildActionMask = 2147483647;
files = (
01598DA713CAE783007344EE /* Foundation.framework in Frameworks */,
01368083147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */,
0164554C147FE90700A76F9F /* libFastPdfKit.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -684,7 +684,7 @@
010D14B213CAF62500FD6F08 /* MediaPlayer.framework in Frameworks */,
959BB88B13D974D2004CB203 /* libziparchive.a in Frameworks */,
3922492614683424004A3EB1 /* NewsstandKit.framework in Frameworks */,
01368082147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */,
0164554B147FE90700A76F9F /* libFastPdfKit.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand All @@ -701,7 +701,7 @@
010D14B113CAF62400FD6F08 /* MediaPlayer.framework in Frameworks */,
010D14B313CAF64000FD6F08 /* AVFoundation.framework in Frameworks */,
010D14B513CAF6DE00FD6F08 /* CFNetwork.framework in Frameworks */,
01368081147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */,
0164554A147FE90700A76F9F /* libFastPdfKit.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand All @@ -726,7 +726,7 @@
buildActionMask = 2147483647;
files = (
958CBAB4141E65770094D4C1 /* (null) in Frameworks */,
01368084147E82E7009E2DAA /* libFastPdfKit.a in Frameworks */,
0164554D147FE90700A76F9F /* libFastPdfKit.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -1177,7 +1177,7 @@
95F5A3511270A2A700F65929 /* FPKCore */ = {
isa = PBXGroup;
children = (
01368080147E82E7009E2DAA /* libFastPdfKit.a */,
01645549147FE90700A76F9F /* libFastPdfKit.a */,
01D73BB51474385300C142FE /* standard14fonts */,
01448A0D134C70A700FD83D8 /* headers */,
);
Expand Down
9 changes: 9 additions & 0 deletions README.md
Expand Up @@ -299,6 +299,15 @@ This guide is also available as [screencast number 4](http://fastpdfkit.com/tuto

## Changelog

### Update 3.1 beta7 (November 25th, 2011)
* Different handling of document view controller dismissal. It is no more necessary
to call -cleanup on the MFDocumentViewController before relasing it. Actual
method implementation does nothing.
* Quite a few small memory leaks fixed.
* Faster page redrawn on page transition (goToPage, setPageMode, etc.).
* MFHomeListPdfs is now BookItemView, be careful if you used to subclass the former
in your project.

### Update 3.1 beta6 (November 21th, 2011)
* Fixed a few errors in Win ANSI and Mac OS Roman encoding. For example, the Unicode
character 'LEFT SINGLE QUOTATION MARK' U+2018 will no more be replaced by
Expand Down

0 comments on commit 8efbf8f

Please sign in to comment.