Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Don't pretend that current Base64 "assertion" works, it doesn't #3

Open
doesdev opened this issue Jan 4, 2018 · 0 comments
Open

Don't pretend that current Base64 "assertion" works, it doesn't #3

doesdev opened this issue Jan 4, 2018 · 0 comments

Comments

@doesdev
Copy link
Owner

doesdev commented Jan 4, 2018

The regex based Base64 check is deeply flawed and caused me to encounter stupid bugs. Probably would if others used this as well. Bottom line is either an encoding assertion is guaranteed or it should not be asserted. Practically speaking that means I probably need to attempt decoding it as base64 and catch an error. Either that or remove the base64 check altogether and follow the chain down.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant