Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] maxTxFee is not set to -maxtxfee if -disablewallet is also active #3087

Closed
junderw opened this issue Aug 4, 2022 · 2 comments · Fixed by #3088
Closed

[bug] maxTxFee is not set to -maxtxfee if -disablewallet is also active #3087

junderw opened this issue Aug 4, 2022 · 2 comments · Fixed by #3088
Labels
Milestone

Comments

@junderw
Copy link
Contributor

junderw commented Aug 4, 2022

Bug Report

Current behavior:
Setting -maxtxfee=1000.00 has no effect when -disablewallet is also active.

Expected behavior
Since sendrawtransaction RPC endpoint is also affected by maxtxfee, it should take effect even when CWallet is never initialized.

Steps to reproduce:

  1. Start dogecoind with -maxtxfee=1000.00 and -disablewallet
  2. Use an external wallet to create a valid batch transaction with an absolute fee > 100 DOGE
  3. Send it using the sendrawtransaction RPC
  4. Get the absurd-high-fee error

Screenshots
None

Dogecoin Core version
v1.14.6

Machine specs

  • OS: Ubuntu 20.04
  • CPU: AWS vCPU (EC2)
  • RAM: 8GB
  • Disk size: 1000GB
  • Disk Type (HD/SDD): HD

Extra information
The only place in the source that checks the -maxtxfee runtime arg is here, but at the top of the function it does an early return true if -disablewallet is active.

@patricklodder
Copy link
Member

Thank you!

@patricklodder
Copy link
Member

Closing this as remaining work is tracked in #3090.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants