Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated flow types breaking flow checking in downstream repo #7

Closed
sandersky opened this issue Nov 21, 2017 · 1 comment
Closed
Labels

Comments

@sandersky
Copy link
Member

Now that this project is generating Flow type files at lib/*.flow, they are breaking Flow type checking in downstream repos with the following error:

Error: node_modules/nodely/lib/master.js.flow:21
 21: declare export default function(argv: $Exact<{output: string, source: string, target: string, verbose: boolean, watch: boolean, workerCount: number}>): {erred: boolean, isWatching: boolean, queue: Array<$Exact<{filePath: string, type: any | any}>>, workers: Array<$Exact<{idle: boolean, worker: Class0}>>};
                                    ^ Unexpected token (

Error: node_modules/nodely/lib/worker.js.flow:9
  9: declare export default function(argv: $Exact<{output: string, source: string, target: string, verbose: boolean, watch: boolean, workerCount: number}>): void;
                                    ^ Unexpected token (

See: facebook/flow#2830

@sandersky sandersky added the bug label Nov 21, 2017
@sandersky
Copy link
Member Author

I've manually fixed these for now by hand by replacing declare export default function(…): … with declare export default (…) => ….

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant