Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout in configuration script #1133

Closed
pki-bot opened this issue Oct 2, 2020 · 2 comments
Closed

Use timeout in configuration script #1133

pki-bot opened this issue Oct 2, 2020 · 2 comments
Milestone

Comments

@pki-bot
Copy link

pki-bot commented Oct 2, 2020

This issue was migrated from Pagure Issue #563. Originally filed by edewata (@edewata) on 2013-03-21 20:16:40:

  • Closed as Fixed
  • Assigned to kaskahn

The current configuration script will attempt 60 times for the Tomcat to start. Ideally it would translate to 60 seconds, but it could also translate to a very long time if each attempt takes a while to complete. The code should be replaced with a proper timeout.

configuration.py:

status = util.instance.wait_for_startup(60)

pkihelper.py:

def wait_for_startup(self, timeout):
    tries = 1   
    status = self.get_instance_status()
    while status != "running":
        if tries >= timeout:
            return None
        time.sleep(1)
        status = self.get_instance_status()
        tries = tries + 1
    return status
@pki-bot pki-bot added this to the 10.0.2 milestone Oct 2, 2020
@pki-bot pki-bot closed this as completed Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from kaskahn at 2013-04-02 23:04:09

Fixed and pushed to master in a698f10

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2017-02-27 14:06:14

Metadata Update from @edewata:

  • Issue assigned to kaskahn
  • Issue set to the milestone: 10.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant