Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the convention and refactoring errors reported by pylint in Dogtag pthon code. #1272

Closed
pki-bot opened this issue Oct 2, 2020 · 4 comments
Milestone

Comments

@pki-bot
Copy link

pki-bot commented Oct 2, 2020

This issue was migrated from Pagure Issue #703. Originally filed by kaskahn on 2013-08-09 18:40:01:

  • Closed at 2018-04-06 14:37:11 as fixed
  • Assigned to nobody

Currently pylint scans cause a build failure only if there are any errors or warnings in the code. All the conventions and refactoring issues are written to a file pylint-report in packages folder. It is required to investigate and fix these issues which improve the code. It can also be discussed if the build must fails if any of these types of issues show up.

@pki-bot pki-bot added this to the 10.6.0 milestone Oct 2, 2020
@pki-bot pki-bot closed this as completed Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2015-02-05 18:39:34

master: dfe5598

There are still other convention and refactoring warnings. This ticket should remain open until all warnings are fixed.

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from kaskahn at 2017-02-27 14:08:59

Metadata Update from @kaskahn:

  • Issue set to the milestone: UNTRIAGED

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2018-04-06 14:37:13

Currently all Python code is checked with pylint and flake8 via CI before commit. All remaining warnings that cannot be fixed right now are explicitly waived.

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2018-04-06 14:37:14

Metadata Update from @edewata:

  • Custom field feature adjusted to None
  • Custom field proposedmilestone adjusted to None
  • Custom field proposedpriority adjusted to None
  • Custom field reviewer adjusted to None
  • Custom field version adjusted to None
  • Issue close_status updated to: fixed
  • Issue set to the milestone: 10.6.0 (was: UNTRIAGED)
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant