Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cfgPath from web.xml #1315

Closed
pki-bot opened this issue Oct 2, 2020 · 2 comments
Closed

Remove cfgPath from web.xml #1315

pki-bot opened this issue Oct 2, 2020 · 2 comments

Comments

@pki-bot
Copy link

pki-bot commented Oct 2, 2020

This issue was migrated from Pagure Issue #748. Originally filed by edewata (@edewata) on 2013-09-27 21:51:34:


Currently the subsystem web.xml contains slots that need to substituted during deployment in order to generate the value for cfgPath parameter:

<servlet>
    <servlet-name>...</servlet-name>
    <servlet-class>com.netscape.cms.servlet.base.CMSStartServlet</servlet-class>
        <init-param>
            <param-name>cfgPath</param-name>
            <param-value>[PKI_INSTANCE_PATH]/conf/[PKI_SUBSYSTEM_TYPE]/CS.cfg</param-value>
        </init-param>
        ...

   </servlet>

The value can actually be computed with this code:

ServletContext servletContext = config.getServletContext();
String instanceDir = System.getProperty("catalina.base");
String subsystem = servletContext.getContextPath().substring(1);
String path = instanceDir + "/conf/" + subsystem + "/CS.cfg";

So the cfgPath can be removed from the web.xml. This way the web.xml no longer needs to be customized for each instance, allowing direct web application deployment in the future. See: http://pki.fedoraproject.org/wiki/Customization#Direct_Deployment

An upgrade script is needed to remove the cfgPath from existing web.xml.

@pki-bot pki-bot added this to the 10.2 - 03/14 (March) milestone Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2014-03-17 18:03:44

master: 4c1ce95

@pki-bot pki-bot closed this as completed Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2017-02-27 14:03:45

Metadata Update from @edewata:

  • Issue assigned to edewata
  • Issue set to the milestone: 10.2 - 03/14 (March)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant