Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self test CLI improvements: #1323

Closed
pki-bot opened this issue Oct 2, 2020 · 5 comments
Closed

Self test CLI improvements: #1323

pki-bot opened this issue Oct 2, 2020 · 5 comments

Comments

@pki-bot
Copy link

pki-bot commented Oct 2, 2020

This issue was migrated from Pagure Issue #756. Originally filed by edewata (@edewata) on 2013-10-07 19:26:38:

  • Closed at 2019-09-25 11:20:05 as fixed
  • Assigned to nobody

Ade wrote:

  1. It would be useful to edit the properties of a self test ie. specify critical/non-critical etc.
  2. It would also be useful to remove, re-add self tests to the Startup. That may require another boolean flag to indicate whether a self test is part of the startup or not.
  3. It would also be valuable to get feedback as to the results of the self tests, wather than just whether or not they executed. This is provided in a popup by the console when self tests are run.
@pki-bot pki-bot added this to the UNTRIAGED milestone Oct 2, 2020
@pki-bot pki-bot closed this as completed Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2017-02-27 14:06:39

Metadata Update from @edewata:

  • Issue set to the milestone: UNTRIAGED

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from dmoluguw (@SilleBille) at 2019-09-25 10:47:10

@edewata

For 1, we have the pki-server selftest-enable and pki-server selftest-disable options.

2 isn't clear

3 is no longer required since we have deprecated console.

If this has been addressed, can we close this ticket?

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from dmoluguw (@SilleBille) at 2019-09-25 10:47:10

Metadata Update from @SilleBille:

  • Custom field feature adjusted to None
  • Custom field reviewer adjusted to None
  • Custom field version adjusted to None
  • Issue close_status updated to: None

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2019-09-25 11:20:05

Here are the selftest properties in CS.cfg:

selftests._000=##
selftests._001=## Self Tests
selftests._002=##
selftests._003=## The Self-Test plugin SystemCertsVerification uses the
selftests._004=## following parameters (where certusage is optional):
selftests._005=## ca.cert.list = <list of cert tag names deliminated by ",">
selftests._006=## ca.cert.<cert tag name>.nickname
selftests._007=## ca.cert.<cert tag name>.certusage
selftests._008=## 
selftests.container.instance.CAPresence=com.netscape.cms.selftests.ca.CAPresence
selftests.container.instance.CAValidity=com.netscape.cms.selftests.ca.CAValidity
selftests.container.instance.SystemCertsVerification=com.netscape.cms.selftests.common.SystemCertsVerification
selftests.container.logger.bufferSize=512
selftests.container.logger.class=com.netscape.cms.logging.RollingLogFile
selftests.container.logger.enable=true
selftests.container.logger.expirationTime=0
selftests.container.logger.fileName=[PKI_INSTANCE_PATH]/logs/[PKI_SUBSYSTEM_TYPE]/selftests.log
selftests.container.logger.flushInterval=5
selftests.container.logger.level=1
selftests.container.logger.maxFileSize=2000
selftests.container.logger.register=false
selftests.container.logger.rolloverInterval=2592000
selftests.container.logger.type=transaction
selftests.container.order.onDemand=CAPresence:critical, SystemCertsVerification:critical, CAValidity:critical
selftests.container.order.startup=CAPresence:critical, SystemCertsVerification:critical
selftests.plugin.CAPresence.CaSubId=ca
selftests.plugin.CAValidity.CaSubId=ca
selftests.plugin.SystemCertsVerification.SubId=ca

Currently we have pki-server <subsystem>-config commands to edit any property in CS.cfg which satisfy 1, and we have pki-server selftest-enable/disable commands which satisfy 2 (ideally they should be moved into pki-server <subsystem>-selftest).

I agree that 3 is not required. Selftests should run before the server is running (or at least as soon as the server is running). I don't think it makes sense to rerun them after the server is running for a while (e.g. what do we do if selftest fails, shutdown the server?), but we do have interface in PKI console and pki <subsystem>-selftest commands for that. Request 3 was referring to the PKI console part. Since we already have a plan for the health check tool, this should no longer be needed. We may also deprecate the pki <subsystem>-selftest commands as well.

I'm closing the ticket. Thanks!

@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2019-09-25 11:20:05

Metadata Update from @edewata:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant