Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing activity logs when formatting/enrolling unknown token #2455

Closed
pki-bot opened this issue Oct 3, 2020 · 4 comments
Closed

Missing activity logs when formatting/enrolling unknown token #2455

pki-bot opened this issue Oct 3, 2020 · 4 comments
Milestone

Comments

@pki-bot
Copy link

pki-bot commented Oct 3, 2020

This issue was migrated from Pagure Issue #2335. Originally filed by edewata (@edewata) on 2016-05-19 00:25:26:

  • Closed as Fixed
  • Assigned to cfu (@cfu)

When formatting an unknown token, TPS will implicitly add the token into the database in addition to formatting the token. However, currently TPS will only log the format operation, the add operation is not recorded in the activity log.

Similarly, when enrolling an unknown token, TPS will only log the enrollment operation, the implicit add and format operations are not logged.

Ideally TPS should record the complete lifecycle of the token, so the above operations should generate the following logs:

  • formatting unknown token: add, format
  • enrolling unknown token: add, format, enrollment
@pki-bot pki-bot added this to the 10.3.2 milestone Oct 3, 2020
@pki-bot pki-bot closed this as completed Oct 3, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2016-05-19 00:34:04

Note that if the allowed transaction list does not include UNFORMATTED -> FORMATTED transition, the unknown token should still be added successfully (and logged), but it will fail to format.

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from mharmsen (@mharmsen) at 2016-05-23 23:19:44

Per CS/DS Meeting of 05/23/2016: 10.3.2

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from cfu (@cfu) at 2016-06-07 02:14:17

Pushed to master:
commit b4b4015

One odd behavior was observed, which I filed a separate bug for:
https://fedorahosted.org/pki/ticket/2354 [TPS] missing activity log entries via UI and CLI (while correctly recorded in LDAP)

@pki-bot
Copy link
Author

pki-bot commented Oct 3, 2020

Comment from edewata (@edewata) at 2017-02-27 14:04:48

Metadata Update from @edewata:

  • Issue assigned to cfu
  • Issue set to the milestone: 10.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant