Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Java sources automatically #634

Closed
pki-bot opened this issue Oct 2, 2020 · 2 comments
Closed

Find Java sources automatically #634

pki-bot opened this issue Oct 2, 2020 · 2 comments

Comments

@pki-bot
Copy link

pki-bot commented Oct 2, 2020

This issue was migrated from Pagure Issue #62. Originally filed by edewata (@edewata) on 2011-11-29 03:28:23:


Currently to compile Java in CMake the source codes have to be listed explicitly as follows:

set(pki-certsrv_java_SRCS
    com/netscape/certsrv/apps/ICommandQueue.java
    com/netscape/certsrv/apps/CMS.java
    com/netscape/certsrv/apps/ICMSEngine.java
    ...
)

Since there are many files this could be a maintenance issue. Ideally the list should be generated with a CMake function, for example:

file(GLOB_RECURSE pki-certsrv_java_SRCS
    RELATIVE .
    PATTERN *.java
)

There's a note in CMake docs (http://cmake.org/cmake/help/cmake-2-8-docs.html#command:file) that warns against it:

We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

However, this not might not be applicable to Java since javac will handle that automatically.

@pki-bot pki-bot added this to the Dogtag 10.0.0.a1 milestone Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

@pki-bot pki-bot closed this as completed Oct 2, 2020
@pki-bot
Copy link
Author

pki-bot commented Oct 2, 2020

Comment from edewata (@edewata) at 2017-02-27 13:58:36

Metadata Update from @edewata:

  • Issue assigned to edewata
  • Issue set to the milestone: Dogtag 10.0.0.a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant