Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate style #169

Closed
hminhman opened this issue Apr 20, 2022 · 2 comments
Closed

Duplicate style #169

hminhman opened this issue Apr 20, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hminhman
Copy link

Describe the bug
This package is verry good and smooth carousel/swiper. It save my day. But I have a trouble when using style prop. After reseach, I found that style will pass to View container and ScrollViewGesture (maybe in Item container too). So when I try to pass a style (for ex: marginHorizontal), it apply 2 time and lead to wrong behavior. So I suggest split style into style (or containerStyle for View container) and scrollStyle.

To Reproduce
Pass style prop.

Expected behavior
Each style prop impact each part of component.

Screenshots
image
image

Versions (please complete the following information):

  • react: v17.0.2
  • react-native: v0.67.2
  • react-native-reanimated: v2.4.1
  • react-native-reanimated-carousel: v2.3.4
  • react-native-gesture-handler: v2.2.0

Smartphone (please complete the following information):

  • Device: simulator iPhone 12
  • OS: iOS 14.5

If I wrong, hope you guide me the right way to pass style prop.
Thanks for your support.

@hminhman hminhman added the bug Something isn't working label Apr 20, 2022
@dohooo dohooo added this to To do in Tasks dashboard. May 1, 2022
@dohooo
Copy link
Owner

dohooo commented May 1, 2022

I'm sorry. I was so busy. I'm back now.

@dohooo
Copy link
Owner

dohooo commented May 1, 2022

Yeah it’s a bug. THX!~

@dohooo dohooo moved this from To do to In test in Tasks dashboard. May 1, 2022
@dohooo dohooo closed this as completed in 7e7e00f May 2, 2022
Tasks dashboard. automation moved this from In test to Done May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants