Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types for style prop incorrect #195

Closed
klandell opened this issue May 23, 2022 · 0 comments
Closed

Typescript types for style prop incorrect #195

klandell opened this issue May 23, 2022 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@klandell
Copy link

Describe the bug
The type for the style prop is:

/**
 * Carousel container style
 */
style?: ViewStyle;

But it should be:

/**
 * Carousel container style
 */
style?: StyleProp<ViewStyle>;

To allow valid type checking with something like:

<ReanimatedCarousel<T> style={[styles.style1, styles.style2]} {...restOfTheProps}  />

Versions (please complete the following information):

  • react-native-reanimated-carousel: v2.4.0
@klandell klandell added the bug Something isn't working label May 23, 2022
@dohooo dohooo added the enhancement New feature or request label May 26, 2022
@dohooo dohooo closed this as completed in c32a98c May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants