Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trading212 support (partial) #6

Closed
wants to merge 2 commits into from
Closed

Conversation

bobcho
Copy link

@bobcho bobcho commented Jan 31, 2021

This adds support for parsing Trading212 statements in csv format in addition to Revolut's pdf statements. Just put all the files in the input folder.

Only partial support for time being - it lacks some activity types because I don't have a full statement at the moment (trading212 takes time to generate the statements and also I don't think I have received any dividends at all so far on their platform).

Includes support for market and limit buy/sell orders only (lacks anything else). Also, output/statements.csv won't have settlement date for trading212 activities as its not included in the t212 export. As settle date is not used anywhere I guess this is fine.

This should not break any current functionality or at least that was my intention.

@bobcho bobcho force-pushed the main branch 2 times, most recently from 3414beb to 11c78ea Compare January 31, 2021 22:26
@doino-gretchenliev
Copy link
Owner

Thank you for your PR. I'll review it soon.

@doino-gretchenliev
Copy link
Owner

I've reviewed the PR and I want to include your parser as supported. In order to develop infrastructure for other parsers, I've isolated the Revolut parser code here. Please, rework your code to extend StatementFilesParser class and place it under libs/parsers/trading212.py. You can use the Revolut parser as an example. That way a user could call the app with -s trading212 and use your parser.

@bobcho bobcho mentioned this pull request Feb 1, 2021
@bobcho
Copy link
Author

bobcho commented Feb 1, 2021

Thanks, added pr #10 with the rework.

I think there is the need to allow multiple -s arguments, allowing simultaneous parsing from multiple sources.

@doino-gretchenliev
Copy link
Owner

Agreed, I'll implement multiple sources.

@bobcho
Copy link
Author

bobcho commented Feb 2, 2021

Agreed, I'll implement multiple sources.

Looking forward to have this implemented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants