Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assassin's Creed Brotherhood: Shadows don't render correctly on AMD #2642

Closed
K0bin opened this issue May 14, 2022 · 2 comments
Closed

Assassin's Creed Brotherhood: Shadows don't render correctly on AMD #2642

K0bin opened this issue May 14, 2022 · 2 comments
Labels
d3d9

Comments

@K0bin
Copy link
Collaborator

K0bin commented May 14, 2022

Initially reported on Discord by EIREXE.

The issue is fairly obvious in this picture:

https://cdn.discordapp.com/attachments/853130811581530145/975008692925767751/unknown.png

Apitraces:

It renders correctly on Nvidia GPUs. @CME42 identified the D24->D32 workaround as the cause of it. Forcing that makes it possible to reproduce it on Nvidia hardware.
@K0bin K0bin added the d3d9 label May 14, 2022
@K0bin K0bin mentioned this issue Jun 11, 2022
Closed
@CME42
Copy link
Contributor

CME42 commented Aug 29, 2022

The issue is due to depth bias, changing the RValue from 1<<23 to 1<<24 for D32 fixes shadow acne.

@K0bin K0bin mentioned this issue Sep 3, 2022
Closed
@Blisto91 Blisto91 mentioned this issue Jun 19, 2023
Merged
@K0bin
Copy link
Collaborator Author

K0bin commented Jun 20, 2023

Fixed by #3501

@K0bin K0bin closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d3d9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to round depth values when using a depth format fallback K0bin/dxvk
2 participants
@K0bin @CME42