Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIFA 19 demo grass render issues.. #642

Closed
oscarbg opened this issue Sep 16, 2018 · 58 comments
Closed

FIFA 19 demo grass render issues.. #642

oscarbg opened this issue Sep 16, 2018 · 58 comments
Labels

Comments

@oscarbg
Copy link

oscarbg commented Sep 16, 2018

Screenshoot:

imagen

logs show no issues..

System information

  • GPU: Titan V
  • Driver: 399.24 (Windows)
  • Wine version: none
  • DXVK version: 0.72

Apitrace file(s)

Log files

@oscarbg
Copy link
Author

oscarbg commented Sep 16, 2018

Also tested with 399.28 which should be equivalent to Linux 396.54.05 with no changes..
FIFA19_demo_dxgi.log

@Leopard1907
Copy link
Contributor

Apitrace?

@doitsujin
Copy link
Owner

doitsujin commented Sep 16, 2018

Game asks for ID3D12Device, which is interesting. But you should know that an apitrace is REQUIRED in such cases, so please add one. I'd also rather have reports from Linux where stuff like nvapi etc. doesn't exist.

@AccountOneOff
Copy link

Fifa 19 demo doesn't work on Wine. https://bugs.winehq.org/show_bug.cgi?id=45830

@oscarbg
Copy link
Author

oscarbg commented Sep 20, 2018

Ok, will add apitrace soon!

@stumts
Copy link

stumts commented Sep 25, 2018

After this patch https://source.winehq.org/git/wine.git/commit/7e39544bfa6cf3e68a8567c202624f7f2d3fc7c8 FIFA 19 have been working on wine.

Look what a strange thing. In the minigame before the match we can see the grass:
captura de tela de 2018-09-24 21-36-54

In the gameplay, we can't see the grass:
captura de tela de 2018-09-24 21-47-48

The game crashes when I try to get a apitrace:
captura de tela de 2018-09-24 21-51-41

@doitsujin
Copy link
Owner

@stumts can you post the full wine console output when running the game?

@stumts
Copy link

stumts commented Sep 25, 2018

Log files

@doitsujin doitsujin added the bug label Sep 25, 2018
@doitsujin
Copy link
Owner

Nothing interesting. Guess I'll take a look when the wine patch lands.

@stumts
Copy link

stumts commented Sep 28, 2018

I don't know if it's useful, but I've tested wined3d and I've gotten the same black grass.
captura de tela de 2018-09-28 20-15-38

@massatt212
Copy link

I get black grass on Windows 2 using dxvk

@Sophtli
Copy link

Sophtli commented Oct 15, 2018

Not even the grass of all stadiums is black. Some work perfectly fine, some are completely black and some are only partially black.

@macskay
Copy link

macskay commented Nov 12, 2018

Black screen also confirmed with following settings:

  • Ubuntu 18.04.01
  • Lutris with DXVK support 0.90
  • esync-staging-pba-3.18
  • AMD Radeon R9 280x

I also have a weird issue, where when my controller is plugged in first it all of the sudden always moves to the right. I need to remove the controller from "Start > Control Center > Gamecontroller", then start the game. Confirm the keyboard as input device (so that the Enter/Space/etc. buttons are shown within the game rather than the XBOX A/B/X/Y buttons) and then move around and play with my controller. This way it does not move arbitrarily.

black-grass

@mozo78
Copy link

mozo78 commented Dec 2, 2018

I can confirm the black grass/stadium problem is here with DXVK 0.93:

1
2

  • Arch Linux
  • DXVK 0.93
  • Wine esync-staging-pba-3.21
  • NVIDIA GTX 1080Ti

@doitsujin
Copy link
Owner

Can anyone record an apitrace? Screenshots aren't exactly helpful, and Origin doesn't work for me.

@mozo78
Copy link

mozo78 commented Dec 2, 2018

The game crashes for me when I try to get an apitrace. I'll try again.
According to wine bug the mentioned wine patch is implemented with 7e39544bfa6cf3e68a8567c202624f7f2d3fc7c8 in Wine 3.17:
https://bugs.winehq.org/show_bug.cgi?id=45523

@mozo78
Copy link

mozo78 commented Dec 2, 2018

Nope the game crashed when I try to get an apitrace. Here you are the log if it can be of some help:

log.zip

@mozo78
Copy link

mozo78 commented Dec 2, 2018

Here is the apitrace to the crash:
https://my.pcloud.com/publink/show?code=XZCTKg7ZOwNnjqAYGQF1NUtCVB75jXAGfBQy

@doitsujin
Copy link
Owner

It's not useful unless it actually shows the grass rendering issue.

@mozo78
Copy link

mozo78 commented Dec 2, 2018

I know but this is I can get :(

@lieff
Copy link

lieff commented Dec 2, 2018

May be try RenderDoc then?
It can be depth bias issue similar to SOTTR on nvidia and can be driver related.

@stumts
Copy link

stumts commented Dec 2, 2018

A user from discord called Aymen has gotten an apitrace from windows.
https://drive.google.com/open?id=1ISC5VdAFD31MUdPOyCQid0ViqzGNsikm

Is it usefull for you? Anyway, I'll try to get the fifa 19 apitrace from wine again.

@4ymen
Copy link

4ymen commented Dec 2, 2018

@stumts yep it's me :)
But your link points weirdly to https://github.com/doitsujin/dxvk/issues/url
here is the apitrace link https://drive.google.com/file/d/1ISC5VdAFD31MUdPOyCQid0ViqzGNsikm/view
Hope it helps

@stumts
Copy link

stumts commented Dec 3, 2018

System Information:

  • SO: Ubuntu 18.04.1
  • GPU: Nvidia GTX 850m
  • Video driver: 415.18.02
  • Wine version: 3.21 (vanilla)
  • DXVK version: 0.93

Apitrace File:

Log Files:

@doitsujin
Copy link
Owner

doitsujin commented Dec 4, 2018

I'm able to reproduce the problem, but I don't think I'll be able to fix this any time soon. The game does actually render the grass just fine, it's just extremely dark for no obvious reason, and I don't have the slightest idea what DXVK might be doing wrong.

@mozo78
Copy link

mozo78 commented Dec 4, 2018

May be it's Wine problem?

@doitsujin
Copy link
Owner

No, it's not. It's quite obviously a DXVK bug but I don't know what it's doing wrong.

@mozo78
Copy link

mozo78 commented Dec 4, 2018

I see, thank you :)

@beyimanman
Copy link

Ok, we'll wait...u are the best!! thnxs for taking the time!

@doitsujin
Copy link
Owner

doitsujin commented Jan 8, 2019

I already figured out what's wrong, only problem is, it's a game bug. I'll have to work around that somehow but it's going to be complicated.

@mozo78
Copy link

mozo78 commented Jan 8, 2019

You are great but you know it :)

@doitsujin
Copy link
Owner

This branch enables raw SSBOs for this game, which should work around the bug. Apitraces still won't replay correctly, but the game itself should work.

Here's a build:
dxvk-fifa.tar.gz

@mozo78
Copy link

mozo78 commented Jan 8, 2019

Yes it works like a charm! Thank you very much!!!

@doitsujin
Copy link
Owner

Thanks for testing, merged into master.

@AccountOneOff
Copy link

That doesn't work for me with the demo.

fifa19

Dxgi reports the exe as fifa19_demo.exe instead of FIFA19_demo.exe

fifa19_demo_dxgi.log

FIFA19_demo_d3d11.log

Works if I set it with dxvk.conf

@stumts
Copy link

stumts commented Jan 8, 2019

There is a known render grass issue in some mobile nvidia GPUs. These GPUs don't render grass. But they're rendering with dxvk.

Fifa 19 on dx11 (windows):
captura de tela 2019-01-08 20 46 10

Fifa 19 on dxvk (ubuntu):
captura de tela de 2019-01-08 20-38-28

@doitsujin , congratulations. Amazing job.

@doitsujin
Copy link
Owner

@AccountOneOff How many different exe names are there? The initial bug report clearly lists it as FIFA2019_demo.exe.

@ZargEzey
Copy link

ZargEzey commented Jan 8, 2019

Awesome work as always. Thanks for fix for Fifa.

@AccountOneOff
Copy link

AccountOneOff commented Jan 8, 2019

I don't know mine is named FIFA19_demo.exe. You're setting the right exe so it should be working but it's not for some reason.

fifa19_demo.exe

I'll try reinstalling.

No difference still doesn't render.

@massatt212
Copy link

massatt212 commented Jan 25, 2019

Is their a FPS Limiter build in to DXVK
This Game drops frames on cut scenes to 20fps instead of steady 60fps all the way through
The Game is Vysnc Bug for Windows, Nvidia Control Pannel Vysnc (on) Fixes the fps drop on cut scenes
But with 60 fps cap ingame launcher option cut scenes are 30 -20fps on scenes, and on No limits fps is 100 druing game play then Vysnc Kicks in at cap its at 60 fps for Cut scenes.
But no limits cause a lot of stutter
So is their a way to limit FPS to 60 ?
Or a Vsync Command built into DXVK to test out ?

@AccountOneOff
Copy link

@massatt212 use librstrangle https://gitlab.com/torkel104/libstrangle

@massatt212
Copy link

Looking rather unstable with steam or have u tried it and it's all good ?

@AccountOneOff
Copy link

I'm not using Proton and no I don't have FIFA 19 just the demo. I have tried it with other games and it helps on those. Namely Beyond Good & Evil.

@sabian2008
Copy link

sabian2008 commented Feb 4, 2019

I don't know mine is named FIFA19_demo.exe. You're setting the right exe so it should be working but it's not for some reason.

Try to launch the game a couple of times and go directly to kick-off. In my case, the 2nd or 3rd try the grass loads and the game works fine.

This takes me to a related question, which I don't know if it is the right place to ask.

When I start the game (FIFA 19 -- no demo --) with Lutris, I can either go directly to kick off (i.e. a quick friendly match), in which case after a couple of tries the grass works ok and works until I close the game in any stadium and game mode. Or I can go to one of the game modes with cinematics.

If I choose kick off first, then choose a game mode with cinematics, the latter run at 1/2 fps and take forever, making the game mode unplayable, because they can't be skipped. If I choose the mode with cinematics first, they render ok (60 fps) but then the grass is always black.

I think I've traced this problem to the GPU memory usage. In the first case, if I'm lucky, I still have GPU memory before the match starts and the grass loads. In the second case, by the time the match is supposed to load I'm out of memory and the appropriate amount of memory is freed to load all the assets but the grass.

My humble my Nvidia 750Ti has twice the minimum required memory in the game specs. I would be surprised if DXVK had a 100% memory footprint. On top of that, the memory consumption seems independent of the rendering options (low, medium, high, ultra) and the anisotropic filtering (0, 2x, 4x). The FPS in gameplay, are independent of this parameter too (I get 50/60 fps on all the combinations, with or without grass), so this certainly seems to me like a bug.

  • Is this a possible bug?
  • If affirmative, should I leave this here or open a new bug?
  • How can I help to track if is this a FIFA, WINE or DXVK bug?

Sorry for the vagueness, I don't know the protocol for reporting things here (and I don't know what that apitrace thing is).

My system:
CPU: Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
RAM: 16 GB
GPU: Nvidia GeForce GTX 750 Ti

OS: Fedora 29
Kernel: 4.20.5
GPU driver: 415.27

Lutris: 0.4.23
Wine: tkg 4.0
DXVK: 0.96

@doitsujin
Copy link
Owner

doitsujin commented Feb 5, 2019

  • Is this a possible bug?

Probably not, although the DXVK memory allocator doesn't handle memory-constrained cards all that well. This isn't trivial to improve and would require a major rewrite of a lot of things, so hoping that Nvidia one day implements VK_EXT_memory_priority on Linux is probably the better solution.

Try running the Nvidia control panel next to the game (the GPU tab shows memory usage), also DXVK_HUD=memory (shows combined vram+system ram usage, might not be super useful).

Also, make sure to close all applications that may eat VRAM (web browsers!) before starting the game. As far as I understand, Nvidia drivers do not support paging out allocations from other apps.

@sabian2008
Copy link

Thanks for the reply!

My observation about VRAM was coming from nvidia-smi, as you suggest, and an htop in the side to see CPU + RAM. After a clean reinstall I managed to make different texture resolution consume different amount of VRAM. However, although the game runs at 120 FPS and has about 300MB VRAM to spare, in some cutscenes the FPS drop to 2 or 3. Anyway, this has gotten too specific to be useful or worth looking into.

Thanks for the great work! Cheers,

@rockybalboa
Copy link

First, thanks for dxvk, it's great. :) It works well with a lot of steam games I have. I tried Fifa19 last night, but it runs a lot slower than on Windows. I don't have a good computer, but I can play Ffifa19 smoothly on Windows with 1080p. But on Linux, the fps is 8-10 on 1080p, and 15-20 on 1600x900. My question is why? I thought dxvk doesn't add any overhead, does it? Can I finetuune it somehow? Maybe esync?

My config:
Distro:Ubuntu Disco Dingo (development branch)
Kernel:5.0.0-7-generic
RAM:10 GB
GPU Driver:NVIDIA 410.104
GPU:NVIDIA GeForce GTX 750
CPU:AMD FX-6300 Six-Core
Wine: 4.4 staging repo
DXVK. 1.0.1

@doitsujin
Copy link
Owner

First of all, check whether you are actually GPU bound (in the nvidia settings). DXVK doesn't run well on old GPUs, especially since yours only has 1GB of VRAM (or is it 2GB?).

@rockybalboa
Copy link

Yes, as I see the GPU is the bottleneck, it only has 1 GB of VRAM. I can get a GTX 670 2 GB, which is a stronger GPU, but as you mentioned DXK doesn't run well on old cards. Should I buy a newer one? What is your recommendation for my setup?

@nonstop13
Copy link

doitsujin, please help on how to fix the black grass on fifa 19

@nonstop13
Copy link

dxvk-fifa.tar.gz
you uploaded this in the past, how do i get to use it so it can work for me as well?

@K0bin
Copy link
Collaborator

K0bin commented Nov 4, 2021

Just use the latest release. It should just work.

@nonstop13
Copy link

i downloaded the fifa 19 repack, it still gives me the same problem

@nonstop13
Copy link

im using hd graphics 5500

@K0bin
Copy link
Collaborator

K0bin commented Nov 4, 2021

We don't support cracked games. That's almost certainly the reason why it doesn't work.

@doitsujin
Copy link
Owner

doitsujin commented Nov 5, 2021

The game does not support Intel graphics and the exact same issue is known to happen on Windows as well on those GPUs.

Also, yeah, do not expect any sort of support for cracked games here.

Repository owner locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests