Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for building Dojo 1 code as part of a build #135

Closed
maier49 opened this issue Aug 20, 2018 · 2 comments
Closed

Provide support for building Dojo 1 code as part of a build #135

maier49 opened this issue Aug 20, 2018 · 2 comments
Labels
enhancement next Issue/Pull Request for the next major version

Comments

@maier49
Copy link
Contributor

maier49 commented Aug 20, 2018

Provide support for building Dojo 1 code as part of a build instead of limiting it to being pulled in as an external.

@agubler agubler added the next Issue/Pull Request for the next major version label Aug 20, 2018
@maier49
Copy link
Contributor Author

maier49 commented Aug 24, 2018

https://github.com/maier49/cli-build-app/tree/dojo-support has an implementation that works on osx, but only because the html-loader has been commented out. If we want this we'll need to address incompatibilities with the html-loader. It's failing in the build time render plugin, but that's actually caused by an underlying issue that can be seen by disabling build time rendering. Specifically dojoLoader is undefined when it's called in html-webpack-plugin's evaluateCompilationResult method so it fails However, this only happens when the html-loader is in the config, otherwise it builds and runs successfully.

Additionally there's a new issue in Windows after updating to the 3.0 build code, where there are quotes that are not properly escaped in some request params.

@maier49
Copy link
Contributor Author

maier49 commented Oct 17, 2018

Because of the number of build issues that kept cropping up with small changes to cli-build-app, as well as some issues with the way global objects are handled that led to problems with dgrid DnD behavior, we decided to drop the effort to build Dojo 1 sources as part of the build. Instead, the externals config in cli-build-app can be leveraged to include pre-built or un-built Dojo 1 code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement next Issue/Pull Request for the next major version
Projects
None yet
Development

No branches or pull requests

2 participants