Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Consider renaming this repo and the published package to 'cli-build-app' #109

Closed
rishson opened this issue Mar 27, 2017 · 6 comments
Closed

Comments

@rishson
Copy link
Contributor

rishson commented Mar 27, 2017

It has been the source of some confusion that the repo is called cli-build but the package is called cli-build-webpack.

I think we should isolate ourselves from a specific implementation (in this case webpack) and rename the repo to cli-build-app and use this name for the published package.

@dylans dylans added this to the 2017.05 milestone Apr 8, 2017
@mwistrand
Copy link

When you say, "build widgets", do you mean generate a new widget? If that is the case, then I would implement that via a dojo create widget command and leave cli-build as it is (and remove the -webpack suffix from the package name).

@rishson
Copy link
Contributor Author

rishson commented May 10, 2017

So the aim of the rename is to have parity between the repo name and the package name on npm.
This has already caused some confusion with beta users in the community.

@mwistrand
Copy link

Yes, I understood that. My question is why not use cli-build for both? If building a single widget consists of generating output for a limited set of files, I do not see why that should require an entirely separate package.

@rishson
Copy link
Contributor Author

rishson commented May 10, 2017

Ahh - OK. I'll remove that section from the description then, as I think that is a fair point and not connected with this issue.

@kitsonk
Copy link
Member

kitsonk commented May 18, 2017

All of our CLI commands follow the same format, irrespective of them being tied to a particular technology. Wouldn't this one be best named cli-build-project even though most users would only have use dojo build as far as we have plans at the moment?

@agubler
Copy link
Member

agubler commented May 18, 2017

It should at least mirror the current published package name to prevent confusion.

Any discussions on a rename could continue after that :)

@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@rishson rishson added beta3 and removed beta2 labels Jun 22, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants