Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests in template project #100

Closed
vansimke opened this issue Sep 12, 2017 · 2 comments
Closed

Update tests in template project #100

vansimke opened this issue Sep 12, 2017 · 2 comments
Assignees
@vansimke
Labels
beta3 bug
Milestone
2017.09

Comments

@vansimke
Copy link
Contributor

tests/unit/App.ts creates a spy for the setProperties function of the HelloWorld class. This method has been renamed __setProperties__ and, as a result, the created test suite fails to create the spy.
@vansimke vansimke self-assigned this Sep 12, 2017
@kitsonk
Copy link
Member

kitsonk commented Sep 13, 2017

We should revisit the tests as a whole, related to #83 instead of fixing what would actually be an anti-pattern.

I would recommend just doing #83 and cleaning the whole mess up.

@kitsonk
Copy link
Member

kitsonk commented Sep 13, 2017

Nevermind, we already merged #101.

We need to mention issues in the commit messages so the issue get closed properly when we merge them.

@kitsonk kitsonk closed this as completed Sep 13, 2017
@kitsonk kitsonk added this to the 2017.09 milestone Sep 13, 2017
@agubler agubler mentioned this issue Sep 13, 2017
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vansimke vansimke

Labels
beta3 bug
Projects
None yet
Milestone
2017.09
Development

No branches or pull requests
2 participants
@kitsonk @vansimke