Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently, the boilerplate depends on dojo/stores and thus compose. #60

Closed
rishson opened this issue Mar 22, 2017 · 1 comment
Closed

Currently, the boilerplate depends on dojo/stores and thus compose. #60

rishson opened this issue Mar 22, 2017 · 1 comment
Milestone
2017.03

Comments

@rishson
Copy link
Contributor

rishson commented Mar 22, 2017

@rishson commented on Wed Mar 22 2017

We should remove the dojo/stores dep from the boilerplate package.json. Whilst the dojo/stores dep is OK in itself, it has a peer dep of dojo/compose so will raise warning on running dojo create if compose is not found.
@rishson rishson mentioned this issue Mar 22, 2017
Closed
@rishson
Copy link
Contributor Author

rishson commented Mar 22, 2017

Ugh - latest dojo/stores has the compose dep removed, as you were.

@rishson rishson closed this as completed Mar 22, 2017
@dylans dylans added this to the 2017.03 milestone Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2017.03
Development

No branches or pull requests
2 participants
@dylans @rishson