Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

request RequestOptions interface should not contain handleAs #134

Closed
tomdye opened this issue Mar 23, 2016 · 2 comments
Closed

request RequestOptions interface should not contain handleAs #134

tomdye opened this issue Mar 23, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@tomdye
Copy link
Member

tomdye commented Mar 23, 2016

Line: https://github.com/dojo/core/blob/master/src/request.ts#L127
The RequestOptions object should not contain handleAs as it's functionality is superseded by the responseType flag.

  • Any current uses of handleAs: 'json' can be replaced with responseType: 'json'
@kitsonk
Copy link
Member

kitsonk commented Mar 27, 2016

@bryanforbes it would be great to get your opinion if this was intended or not.

@kitsonk kitsonk added the bug label Mar 27, 2016
@kitsonk kitsonk added this to the beta.1 milestone Mar 27, 2016
@tomdye
Copy link
Member Author

tomdye commented Mar 29, 2016

@bryanforbes commented in a chat window previously saying that a decision had been made to go with responseType over handleAs. The design documentation does not include handleAs in the interface for RequestOptions

@kitsonk kitsonk modified the milestones: 2016.04, beta.1 Apr 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants