request `RequestOptions` interface should not contain `handleAs` #134

Closed
Tomdye opened this Issue Mar 23, 2016 · 2 comments

Projects

None yet

2 participants

@Tomdye
Member
Tomdye commented Mar 23, 2016

Line: https://github.com/dojo/core/blob/master/src/request.ts#L127
The RequestOptions object should not contain handleAs as it's functionality is superseded by the responseType flag.

  • Any current uses of handleAs: 'json' can be replaced with responseType: 'json'
@Tomdye Tomdye self-assigned this Mar 23, 2016
@kitsonk
Member
kitsonk commented Mar 27, 2016

@bryanforbes it would be great to get your opinion if this was intended or not.

@kitsonk kitsonk added the bug label Mar 27, 2016
@kitsonk kitsonk added this to the beta.1 milestone Mar 27, 2016
@Tomdye
Member
Tomdye commented Mar 29, 2016

@bryanforbes commented in a chat window previously saying that a decision had been made to go with responseType over handleAs. The design documentation does not include handleAs in the interface for RequestOptions

@kitsonk kitsonk modified the milestone: 2016.04, beta.1 Apr 8, 2016
@kitsonk kitsonk closed this in #135 Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment