Fixes direction to be render-forward for all plots and themes, fixes #18... #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-ms-user-select CSS property anymore.
Line endings in dojo (and most repositories) must be \n, not \n\r.
Necessary to generate API doc. Tweak was overwritten by ab5ea21 (refs #17822).
… modification. fixes: 18060
Chrome clears the file input value when the file selection dialog is cleared. If a file was already chosen this creates a change, but the data array provided to `onChange` wasn't accounting for this so a dummy file object gets passed instead of an array.
…lds size with ios7 theme.
…tion/deserialization of a VML surface. Squashed commit of the following: commit 7c87313 Author: Jared Jurkiewicz <jared.jurkiewicz@gmail.com> Date: Mon Jul 28 11:09:12 2014 -0400 Fix patth repeated duplication error in VML renderer, fixes #16830
…ot node had css settings. fixes: #18081
commit d60e612 Author: Jared Jurkiewicz <jared.jurkiewicz@gmail.com> Date: Tue Jun 10 11:21:50 2014 -0400 Fix issue with dojox/html/metrics and font size, fixes #18080
commit c7e6a45 Author: Nicola Rizzo <nicola.rizzo@gmail.com> Date: Sat Jul 26 19:51:30 2014 +0200 corrects the year number, fixes #17835; test updated
commit 4306992 Author: Jared Jurkiewicz <jared.jurkiewicz@gmail.com> Date: Fri Aug 15 13:15:54 2014 -0400 Fix issue with target node check, make sure it isn't root/body, fixes #18222
Refs #12863, #17829
… to exclude for the build system
Squashed commit of the following: commit a475eec Author: Arūnas Rukšnaitis <github@ruksnaitis.com> Date: Tue Apr 28 20:27:36 2015 +0100 #18533 dojox/lang/functional zip.js and curry.js in AMD style (broken in 1.10.4)
Thanks to youngho (CLA on file) for patch. Also did some lint cleanup. Fixes #18619.
Fixes an issue where any widget using Selection.js (such as dojox/Calendar) is only able to multi-select if you control-click, even on OSX. (Unfortunately for them, control-click also simulates the Windows right-click behavior, making the browser context menu appear.)
…than 8 characters
|
@Kagetsume do you want to go ahead and land this one? |
|
Sure, I'll merge it today. I've been swamped. Sorry for the delay on these. |
|
I have merged this into master. Therefore, closing pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to enhancement/defect: https://bugs.dojotoolkit.org/ticket/18061
It is a simple patch to the plots to reverse the draw order so it draws theme-forward consistently (theme entry 0 goes to series 0, theme entry 1 to series 1, and so on). Prior to this some plots rendered reverse order, some rendered forward. It made it inconsistent when displaying several cart types together in terms of their draw color sequence. This also makes it simpler to build new themes as the draw order makes more sense.
I verified in the current/modern dojo code base this does not affect the way stack charts render, they still render properly stacked, just with theme color draws in forward order.